This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Expose Batcher#sendOutstanding to provide async batch flushing #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now `Batcher` supports asynchronously batching. This is needed to support HBase client's [BulkMutation#sendUnsent](https://github.com/googleapis/java-bigtable-hbase/blob/master/bigtable-client-core-parent/bigtable-client-core/src/main/java/com/google/cloud/bigtable/core/IBulkMutation.java#L37-L38) through GCJ client.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #786 +/- ##
=========================================
Coverage 78.39% 78.39%
Complexity 1106 1106
=========================================
Files 198 198
Lines 4887 4887
Branches 385 385
=========================================
Hits 3831 3831
Misses 887 887
Partials 169 169
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
Batchersupports asynchronously batching.Note: This is needed to support HBase client's BulkMutation#sendUnsent through GCJ client.