Commits on Sep 5, 2019

1. Fix Race condition when shutting down executor/transport channel …

   This fix only changes the order of shutdowns (first transportChannel and only then the Executor). This the most lightweight fix we can make, which should fix the issue. We would like to avoid enforcing `awaitTermination()` on `shutdown()` because that would convert non-blocking call (`shutdown()`) to a blocking one with great potential of having non-desirable side-effects. Also this may potentially require surface changes on gax (potentially requiring major version bump on gax), because currently `shutdown()` is widely used, it is declared in a public interface and is explicitly specified as non-blocking operation.

   

   vam-google committed Sep 5, 2019
   Copy the full SHA

   9d86f11 View commit details

   Browse the repository at this point in the history