Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Track number of failure in batching when Batcher#close is called #800

Merged
merged 11 commits into from Nov 4, 2019
Merged

Track number of failure in batching when Batcher#close is called #800

merged 11 commits into from Nov 4, 2019

Commits on Oct 21, 2019

  1. Track number of failure for Batcher when Batcher#close is called. 

    Adding test case for BatchingException.
    @rahulKQL
    rahulKQL committed Oct 21, 2019
    Copy the full SHA
    37063ef View commit details
    Browse the repository at this point in the history

  2. Removed BatchingException#toString() to only log total failure count

    @rahulKQL
    rahulKQL committed Oct 21, 2019
    Copy the full SHA
    e30e82a View commit details
    Browse the repository at this point in the history

  3. Introduced BatchStats for failures occurred during batching 

    Now BatchStats will keep the counter for each type of exception happened at RPC as well as ElementT/entry object level.

Also refactored exception message to be more detailed.
    @rahulKQL
    rahulKQL committed Oct 21, 2019
    Copy the full SHA
    45960f1 View commit details
    Browse the repository at this point in the history

  4. fixed license header for BatchStats.java

    @rahulKQL
    rahulKQL committed Oct 21, 2019
    Copy the full SHA
    ecfe7f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2019

  1. Updated partial failure counting logic to only come in effect when RP… 

    …C is successful.
    @rahulKQL
    rahulKQL committed Oct 22, 2019
    Copy the full SHA
    aa5ec0b View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. Updated BatcherStats to accept Throwable and List of ResultFutures 

    Addressed feedback comments to simplify BatcherStats
    @rahulKQL
    rahulKQL committed Oct 23, 2019
    Copy the full SHA
    1c9fe27 View commit details
    Browse the repository at this point in the history

  2. Updated BatcherStats to address feedback comments

    @rahulKQL
    rahulKQL committed Oct 23, 2019
    Copy the full SHA
    e23f6b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. Address more feedback comments 

    - Refactored record methods in BatcherImpl.Batch.
- Removed callback and implemented try/catch for entry failures.
- Made all three default method synchronized and removed lock as all the content of method needed to be inside lock.
- Fixed test case and added a todo for followUp PR.
    @rahulKQL
    rahulKQL committed Oct 24, 2019
    Copy the full SHA
    de6a96f View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. Updated TODO for follow up PR

    @rahulKQL
    rahulKQL committed Oct 29, 2019
    Copy the full SHA
    cdbf5c1 View commit details
    Browse the repository at this point in the history

  2. fixed the name of oldStatusCount

    @rahulKQL
    rahulKQL committed Oct 29, 2019
    Copy the full SHA
    cbc0acf View commit details
    Browse the repository at this point in the history

  3. Fixed variables names to be descriptive

    @rahulKQL
    rahulKQL committed Oct 29, 2019
    Copy the full SHA
    60705f7 View commit details
    Browse the repository at this point in the history