Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

cleanup(batcher): removing the non-applicable TODOs comments #834

Merged
merged 2 commits into from Dec 27, 2019
Merged

cleanup(batcher): removing the non-applicable TODOs comments #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dfefca
fix(batcher): fix logged messge when exception occurs post processing
rahulKQL Dec 16, 2019
8f34639
removed unnecessary batcher message changes, Also reverted the Batche…
rahulKQL Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions gax/src/main/java/com/google/api/gax/batching/BatcherImpl.java
View file
Open in desktop
Expand Up @@ -256,8 +256,6 @@ void add(ElementT element, SettableApiFuture<ElementResultT> result) {
byteCounter += descriptor.countBytes(element);
}

// TODO: Ensure that all results are resolved in case the descriptor that causes it to
// process all results or throw an exception during processing
void onBatchSuccess(ResponseT response) {
try {
descriptor.splitResponse(response, results);
Expand Down
1 change: 0 additions & 1 deletion gax/src/test/java/com/google/api/gax/batching/BatcherImplTest.java
View file
Open in desktop
Expand Up @@ -509,7 +509,6 @@ public void splitResponse(
+ "3 entries that failed with: 3 ArithmeticException.");
}

// TODO(rahulkql): fix this test with follow up PR related to exception in splitResponse.
@Test
public void testPartialFailureInResultProcessing() throws Exception {
final Queue<RuntimeException> queue = Queues.newArrayBlockingQueue(3);
Expand Down