Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

deps: update jacoco to 0.8.5 #883

Merged
merged 1 commit into from Feb 26, 2020
Merged

Conversation

kolea2
Copy link
Contributor

@kolea2 kolea2 commented Feb 26, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2020
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #883 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #883      +/-   ##
============================================
+ Coverage     78.43%   78.63%   +0.19%     
- Complexity     1156     1163       +7     
============================================
  Files           203      203              
  Lines          5110     5143      +33     
  Branches        402      413      +11     
============================================
+ Hits           4008     4044      +36     
+ Misses          926      925       -1     
+ Partials        176      174       -2
Impacted Files Coverage Δ Complexity Δ
...oogle/api/gax/httpjson/ManagedHttpJsonChannel.java 54% <0%> (-1.11%) 5% <0%> (ø)
...a/com/google/api/gax/grpc/GrpcCallableFactory.java 82.5% <0%> (-1.05%) 11% <0%> (ø)
...m/google/api/gax/httpjson/HttpJsonCallOptions.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
.../google/api/gax/retrying/TimedAttemptSettings.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
...m/google/api/gax/httpjson/ApiMethodDescriptor.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
...api/gax/httpjson/ApiMessageHttpResponseParser.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/com/google/api/gax/rpc/BatcherFactory.java 95.12% <0%> (+0.12%) 9% <0%> (+2%) ⬆️
.../java/com/google/api/gax/grpc/GrpcClientCalls.java 95.65% <0%> (+0.19%) 7% <0%> (ø) ⬇️
.../java/com/google/api/gax/grpc/CallOptionsUtil.java 95.45% <0%> (+0.21%) 6% <0%> (ø) ⬇️
...httpjson/InstantiatingHttpJsonChannelProvider.java 70.96% <0%> (+0.47%) 19% <0%> (ø) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5440bc6...3492e93. Read the comment docs.

@kolea2
Copy link
Contributor Author

kolea2 commented Feb 26, 2020

@suztomo I tried originally taking the approach you had for the java format plugin (onlyIf java 8), but couldn't get it to work - I am not super familiar with gradle so any suggestions appreciated. Instead, I was able to upgrade jacoco for all language levels. Any objections @chingor13 ? This will at least get all builds passing for now.

@suztomo
Copy link
Member

suztomo commented Feb 26, 2020

@kolea2 Nice to see Java 11 build works now and Jacoco plugin upgraded. (My previous attempt failure could be temporary one). 2 birds 1 stone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants