Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: turned google-proto-files into a dev dependency #470

Merged
merged 13 commits into from Apr 27, 2019

Conversation

hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Apr 18, 2019

Fixes #469

This PR changes the dependency on google-proto-files into a dev dependency, and adds a script which bundles the required proto files into google-gax itself. This increases the size of the google-gax by about 750KB, but saves users about 10MB in the process. Appreciate your feedback on this solution.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 18, 2019
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #470 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #470   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files           1        1           
  Lines         333      333           
=======================================
  Hits          296      296           
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b4d3b...c535881. Read the comment docs.

@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
package.json Outdated Show resolved Hide resolved
@alexander-fenster
Copy link
Member

Thank you for doing this! I'm OK with the logic of this change, the only concern I have is that we don't have a real consumer test for gax (i.e. the test that will npm pack the package and verify it can be consumed correctly, checking all the features including those requiring the extra protos such as long running operations).

I'm working on adding such a test this week so if you don't mind let's hold this PR until such test is there (hopefully today or tomorrow) and then we'll be able to make this change being confident that nothing is broken.

@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 25, 2019
@JustinBeckwith JustinBeckwith added status: blocked Resolving the issue is dependent on other work. and removed 🚨 This issue needs some love. labels Apr 26, 2019
@JustinBeckwith
Copy link
Contributor

Marking this as blocked on #471

Copy link
Member

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates!

@alexander-fenster alexander-fenster changed the title Turned google-proto-files into a dev dependency feat: turned google-proto-files into a dev dependency Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop the dependency on google-proto-files in favor of something smaller
6 participants