New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: turned google-proto-files into a dev dependency #470
Conversation
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
=======================================
Coverage 88.88% 88.88%
=======================================
Files 1 1
Lines 333 333
=======================================
Hits 296 296
Misses 37 37 Continue to review full report at Codecov.
|
Thank you for doing this! I'm OK with the logic of this change, the only concern I have is that we don't have a real consumer test for gax (i.e. the test that will I'm working on adding such a test this week so if you don't mind let's hold this PR until such test is there (hopefully today or tomorrow) and then we'll be able to make this change being confident that nothing is broken. |
Marking this as blocked on #471 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates!
Fixes #469
This PR changes the dependency on
google-proto-files
into a dev dependency, and adds a script which bundles the required proto files intogoogle-gax
itself. This increases the size of thegoogle-gax
by about 750KB, but saves users about 10MB in the process. Appreciate your feedback on this solution.