Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to .nycrc with --all enabled #476

Merged
merged 1 commit into from Apr 29, 2019
Merged

update to .nycrc with --all enabled #476

merged 1 commit into from Apr 29, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Apr 29, 2019

to work properly, nyc should also be updated to 14

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2019
@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #476 into master will decrease coverage by 6.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   88.88%   82.83%   -6.06%     
==========================================
  Files           1       50      +49     
  Lines         333     3198    +2865     
  Branches        0       82      +82     
==========================================
+ Hits          296     2649    +2353     
- Misses         37      536     +499     
- Partials        0       13      +13
Impacted Files Coverage Δ
src/createApiCall.ts 90.47% <0%> (ø)
src/index.ts 86.36% <0%> (ø)
src/streamingCalls/streamingApiCaller.ts 76.47% <0%> (ø)
test/utils.ts 91.66% <0%> (ø)
src/parserExtras.ts 100% <0%> (ø)
src/descriptor.ts 100% <0%> (ø)
test/routingHeader.ts 100% <0%> (ø)
test/grpc.ts 93.16% <0%> (ø)
src/longRunningCalls/longRunningDescriptor.ts 100% <0%> (ø)
src/normalCalls/retries.ts 92.15% <0%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6693d5d...4577a48. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #476 into master will decrease coverage by 6.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   88.88%   82.83%   -6.06%     
==========================================
  Files           1       50      +49     
  Lines         333     3198    +2865     
  Branches        0       82      +82     
==========================================
+ Hits          296     2649    +2353     
- Misses         37      536     +499     
- Partials        0       13      +13
Impacted Files Coverage Δ
src/createApiCall.ts 90.47% <0%> (ø)
src/index.ts 86.36% <0%> (ø)
src/streamingCalls/streamingApiCaller.ts 76.47% <0%> (ø)
test/utils.ts 91.66% <0%> (ø)
src/parserExtras.ts 100% <0%> (ø)
src/descriptor.ts 100% <0%> (ø)
test/routingHeader.ts 100% <0%> (ø)
test/grpc.ts 93.16% <0%> (ø)
src/longRunningCalls/longRunningDescriptor.ts 100% <0%> (ø)
src/normalCalls/retries.ts 92.15% <0%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6693d5d...4577a48. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit b9e7073 into master Apr 29, 2019
@JustinBeckwith JustinBeckwith deleted the nycrc-update branch April 29, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants