Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Call GAPIC client using positional args #208

Merged
merged 1 commit into from May 30, 2019
Merged

Call GAPIC client using positional args #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/google/gax/operation.rb
View file
Open in desktop
Expand Up @@ -214,7 +214,7 @@ def cancel options: nil
# Converts hash and nil to an options object
options = ApiCall::Options.new options.to_h if options.respond_to? :to_h

@client.cancel_operation name: @grpc_op.name, options: options
@client.cancel_operation({ name: @grpc_op.name }, options)
end

##
Expand All @@ -227,7 +227,7 @@ def delete options: nil
# Converts hash and nil to an options object
options = ApiCall::Options.new options.to_h if options.respond_to? :to_h

@client.delete_operation name: @grpc_op.name, options: options
@client.delete_operation({ name: @grpc_op.name }, options)
end

##
Expand All @@ -242,7 +242,7 @@ def reload! options: nil
# Converts hash and nil to an options object
options = ApiCall::Options.new options.to_h if options.respond_to? :to_h

gax_op = @client.get_operation name: @grpc_op.name, options: options
gax_op = @client.get_operation({ name: @grpc_op.name }, options)
@grpc_op = gax_op.grpc_op

if done?
Expand Down