Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: translate GaxiosError message to object regardless of return type #537

Merged
merged 5 commits into from Jun 23, 2023
Merged

fix: translate GaxiosError message to object regardless of return type #537

merged 5 commits into from Jun 23, 2023

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented May 31, 2023

Fixes #529

@sofisl sofisl requested a review from a team as a code owner May 31, 2023 00:29
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 31, 2023
@sofisl sofisl added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 31, 2023
@sofisl sofisl changed the title fix: translate GaxiosError message to string fix: translate GaxiosError message to object regardless of return type May 31, 2023
ddelgrosso1
ddelgrosso1 approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddelgrosso1 ddelgrosso1 merged commit 563c653 into main Jun 23, 2023
14 checks passed
@ddelgrosso1 ddelgrosso1 deleted the translateErrorToString branch June 23, 2023 15:50
@release-please release-please bot mentioned this pull request Jun 23, 2023
Merged
@ddelgrosso1 ddelgrosso1 restored the translateErrorToString branch June 25, 2023 14:54
ddelgrosso1 added a commit that referenced this pull request Jun 25, 2023
@ddelgrosso1
Revert "fix: translate GaxiosError message to object regardless of re…
4850143 
…turn type (#537)"

This reverts commit 563c653.
@ddelgrosso1 ddelgrosso1 mentioned this pull request Jun 25, 2023
Merged
ddelgrosso1 added a commit that referenced this pull request Jun 25, 2023
@ddelgrosso1
Revert "fix: translate GaxiosError message to object regardless of re…
b09e6b9 
…turn type (#537)" (#543)

This reverts commit 563c653.
@sofisl sofisl mentioned this pull request Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect GaxiosError message type when request responseType "arrayBuffer"
4 participants
@sofisl @alexander-fenster @ddelgrosso1 @yoshi-kokoro