Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency https-proxy-agent to v7 #539

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jun 3, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
https-proxy-agent ^5.0.0 -> ^7.0.0 age adoption passing confidence

Release Notes

TooTallNate/proxy-agents

v7.0.0

Compare Source

Major Changes
  • b3860aa: Remove secureProxy getter

    It was not meant to be a public property. If you were using it, just use agent.proxy.protocol === 'https:' instead.

v6.2.1

Compare Source

Patch Changes
  • 0b8a0b7: Properly reject errors during proxy CONNECT response

v6.2.0

Compare Source

Minor Changes
  • 8ff9faa: "headers" option can now be a function
Patch Changes
  • Updated dependencies [66b4c63]
    • agent-base@7.0.2

v6.1.0

Minor Changes
  • fd6209c: Emit "proxyConnect" event on HTTP request object (part of #​153)
  • c573dbe: Emit "proxyConnect" event on Agent instance
Patch Changes
  • 7674748: Update @types/node to v14.18.45
  • Updated dependencies [7674748]
    • agent-base@7.0.1

v6.0.0

Major Changes
  • d99a7c8: Major version bump for all packages
    • ⚠️ This is a breaking change! The HttpsProxyAgent constructor argument has been split into two arguments.
Upgrading from 5.x to 6.x

In version 5.x, the HttpsProxyAgent constructor took a single argument of either (A) a string, or (B) an object matching the output of
the deprecated url.parse() method
and various extra options.

Now the constructor takes two separate arguments:

  • Argument 1: Either (A) a string, or (B) a WHATWG URL object
  • Argument 2 (optional): An object with standard http.Agent,
    net.TcpNetConnectOpts, and tls.ConnectionOptions properties and/or custom options supported by this package.

If you were using an object argument in 5.x, you'll need to change the first argument to match the structure of the URL class, and move
any other options to the second argument.

5.x usage:

const agent = new HttpsProxyAgent({
  protocol: 'https:',
  host: 'myproxy.mydomain.com'
  port: '1234',
  auth: 'proxyUser:proxyPass',
  timeout: 1000,
  headers: { 'trace', 'foo' }
});

Updated 6.x usage:

const agent = new HttpsProxyAgent(
  'https://proxyUser:proxyPass@myproxy.mydomain.com:1234',
  {
    timeout: 1000,
    headers: { 'trace', 'foo' }
  }
);
Minor Changes
  • 4333067: Add support for core keepAlive: true
Patch Changes
  • c169ced: Convert mocha tests to jest for all packages
  • 06775a8: Add test for rejectUnauthorized: false missing on request options
  • Updated dependencies [c169ced]
  • Updated dependencies [d99a7c8]
  • Updated dependencies [4333067]
    • agent-base@7.0.0

Configuration

📅 Schedule: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team as a code owner June 3, 2023 11:05
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 3, 2023
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jun 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2023
@renovate-bot renovate-bot force-pushed the renovate/https-proxy-agent-7.x branch from 4a6d403 to 04e113d Compare June 23, 2023 15:41
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 23, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 23, 2023
@ddelgrosso1
Copy link
Contributor

Closing as this requires Node >= 14.

@forking-renovate
Copy link

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 7.x releases. But if you manually upgrade to 7.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@benasher44
Copy link

@ddelgrosso1 can this be reopened now that this library is node 14+? The release notes make it seem like there are fixes for keepAlive: true

@ddelgrosso1
Copy link
Contributor

@benasher44 I have raised a PR to update to 7.0.1: #560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants