feat: return text when content type is text/csv #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/gaxios.ts
Outdated
| @@ -404,6 +404,7 @@ export class Gaxios { | |||
| return data as {}; | |||
| } else if ( | |||
| contentType.includes('text/plain') || | |||
| contentType.includes('text/csv') || | |||
There was a problem hiding this comment.
Now I'm just thinking if we should instead do contentType.startsWith('text/') and consider all text content the same. @sofisl what do you think?
There was a problem hiding this comment.
I agree! Would you mind including a regex instead? and maybe a .match? Thank you!
alexander-fenster
approved these changes
Oct 13, 2023
alexander-fenster
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
sofisl
requested changes
Oct 13, 2023
src/gaxios.ts
Outdated
| @@ -404,6 +404,7 @@ export class Gaxios { | |||
| return data as {}; | |||
| } else if ( | |||
| contentType.includes('text/plain') || | |||
| contentType.includes('text/csv') || | |||
There was a problem hiding this comment.
I agree! Would you mind including a regex instead? and maybe a .match? Thank you!
vinteo
commented
Oct 14, 2023
| contentType.includes('text/plain') || | ||
| contentType.includes('text/html') | ||
| ) { | ||
| } else if (contentType.match(/^text\//)) { |
There was a problem hiding this comment.
not sure how specific the regular expression should be, hope this suits.
danielbankhead
changed the title
danielbankhead
approved these changes
Dec 6, 2023
|
Any chance of pushing this through? |
sofisl
approved these changes
Jan 30, 2024
danielbankhead
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #578 馃