Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Standardize baseURL #600

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat!: Standardize baseURL #600

wants to merge 3 commits into from

Conversation

danielbankhead
Copy link
Member

Notable changes:

  • Remove long-deprecated baseUrl
  • Use proper base URL logic via new URL(url, base)

馃

@danielbankhead
feat!: Standardize baseURL
8490f24 
- Remove long-deprecated `baseUrl`
- Use proper `base` URL logic via `new URL(url, base)`
@danielbankhead danielbankhead requested a review from a team as a code owner February 1, 2024 03:51
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 1, 2024
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

@danielbankhead danielbankhead added semver: major Hint for users that this is an API breaking change. next major: breaking change this is a change that we should wait to bundle into the next major version do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed size: s Pull request size is small. labels Feb 1, 2024
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. next major: breaking change this is a change that we should wait to bundle into the next major version semver: major Hint for users that this is an API breaking change. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danielbankhead