option: remove experimental API WithGRPCConnectionPool #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@jadekler - can you take a look? |
|
-2 on this CL. I'll work on this. Thanks for raising.
…On Mon, Jan 13, 2020, 11:46 AM Jean de Klerk ***@***.***> wrote:
Ooo, yikes, this one is bad. I'm OOO and also no longer on client
libraries - paging @tbpg <https://github.com/tbpg>, @codyoss
<https://github.com/codyoss>, @broady <https://github.com/broady> .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#442?email_source=notifications&email_token=AAAGDFQBJ6QU4IZLKGS6NYTQ5TALHA5CNFSM4KGFTIQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI2BFPI#issuecomment-573838013>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGDFQGDMNUVKFEIWK5BPDQ5TALHANCNFSM4KGFTIQA>
.
|
|
Note we do make use of the option in google-cloud-go in a couple of spots as well. |
|
This is an immediate fix to all users that do not depend upon the experimental parts of this package. I would recommend submitting it to unbreak people while you work on a full fix. Note that any package which contains a dependency on any experimental code should be considered experimental in its entirety. So I would recommend re-adding the experimental functionality in a separate package. |
|
as discussed, fix is in progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experimental APIs relied upon by this option were deleted in grpc/grpc-go#3301
Fixes #441