New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add error description to batch emptiness validation #2109

Merged

BenWhitehead merged 1 commit into main from better-validation-message

Jul 15, 2022

Contributor

BenWhitehead commented Jul 14, 2022

When invoking BatchRequest#execute(), we ensure the batch contains at
least one request to process. Previously this check, did not provide any
error message. Now, if the check fails "Batch is empty" will be the
message of the resulting exception.

Related to googleapis/java-storage#694


          fix: add error description to batch emptiness validation

8314bdf

When invoking BatchRequest#execute(), we ensure the batch contains at
least one request to process. Previously this check, did not provide any
error message. Now, if the check fails "Batch is empty" will be the
message of the resulting exception.

Related to googleapis/java-storage#694

BenWhitehead requested a review from a team as a code owner

July 14, 2022 15:50

product-auto-label bot added the size: xs label

BenWhitehead mentioned this pull request

StorageBatch get IllegalStateException googleapis/java-storage#694

Closed

Neenu1995 approved these changes

View reviewed changes

TimurSadykov approved these changes

View reviewed changes

Member

TimurSadykov left a comment

LGTM

BenWhitehead merged commit 2668dd1 into main

BenWhitehead deleted the better-validation-message branch

July 15, 2022 17:52

release-please bot mentioned this pull request

chore(main): release 2.0.1 #2111

Merged

gcf-merge-on-green bot pushed a commit that referenced this pull request


          chore(main): release 2.0.1 (#2111)

c50ae4c

🤖 I have created a release *beep* *boop*
---


## [2.0.1](https://togithub.com/googleapis/google-api-java-client/compare/v2.0.0...v2.0.1) (2022-11-05)


### Bug Fixes

* Add error description to batch emptiness validation ([#2109](https://togithub.com/googleapis/google-api-java-client/issues/2109)) ([2668dd1](https://togithub.com/googleapis/google-api-java-client/commit/2668dd1348e7710a83e008b1e2b2ff6fceedfedf))
* **deps:** Update dependency com.google.api-client:google-api-client to v2 ([#2108](https://togithub.com/googleapis/google-api-java-client/issues/2108)) ([570a162](https://togithub.com/googleapis/google-api-java-client/commit/570a1625fbb3806961d328d90d784b5f0ed21a0c))
* **deps:** Update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.10 ([#2174](https://togithub.com/googleapis/google-api-java-client/issues/2174)) ([9077b4a](https://togithub.com/googleapis/google-api-java-client/commit/9077b4ae4c4214cb0fdcb5248f8c7ecbeb51d27f))
* **deps:** Update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.6 ([#2124](https://togithub.com/googleapis/google-api-java-client/issues/2124)) ([51adc54](https://togithub.com/googleapis/google-api-java-client/commit/51adc541819284dabcdefef39fa39b4a0bd13f6a))
* **deps:** Update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.7 ([#2131](https://togithub.com/googleapis/google-api-java-client/issues/2131)) ([6892bb2](https://togithub.com/googleapis/google-api-java-client/commit/6892bb293ca578b793fe0024c884b21e675abd45))
* **deps:** Update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.8 ([#2140](https://togithub.com/googleapis/google-api-java-client/issues/2140)) ([bb6f19c](https://togithub.com/googleapis/google-api-java-client/commit/bb6f19ce2a89f6d419c908eff7faa944ea74799e))
* **deps:** Update dependency com.google.cloud:libraries-bom to v26.1.0 ([#2126](https://togithub.com/googleapis/google-api-java-client/issues/2126)) ([3d0e0ff](https://togithub.com/googleapis/google-api-java-client/commit/3d0e0ff57cde5ca9eb56e5266dc5c37f3777179d))
* **deps:** Update dependency com.google.cloud:libraries-bom to v26.1.1 ([#2134](https://togithub.com/googleapis/google-api-java-client/issues/2134)) ([15ce062](https://togithub.com/googleapis/google-api-java-client/commit/15ce06244a06b64545f145a2ebdfb62863fcbad4))
* **deps:** Update dependency com.google.cloud:libraries-bom to v26.1.2 ([#2143](https://togithub.com/googleapis/google-api-java-client/issues/2143)) ([da2f6f3](https://togithub.com/googleapis/google-api-java-client/commit/da2f6f3e4645ff3b84465943833404526077ad20))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

blakeli0 pushed a commit that referenced this pull request


          fix: add error description to batch emptiness validation (#2109)

3f54db6

When invoking BatchRequest#execute(), we ensure the batch contains at
least one request to process. Previously this check, did not provide any
error message. Now, if the check fails "Batch is empty" will be the
message of the resulting exception.

Related to googleapis/java-storage#694

blakeli0 pushed a commit that referenced this pull request


          chore(main): release 2.0.1 (#2111)

0ea00da

🤖 I have created a release *beep* *boop*
---


## [2.0.1](https://togithub.com/googleapis/google-api-java-client/compare/v2.0.0...v2.0.1) (2022-11-05)


### Bug Fixes

* Add error description to batch emptiness validation ([#2109](https://togithub.com/googleapis/google-api-java-client/issues/2109)) ([2668dd1](https://togithub.com/googleapis/google-api-java-client/commit/2668dd1348e7710a83e008b1e2b2ff6fceedfedf))
* **deps:** Update dependency com.google.api-client:google-api-client to v2 ([#2108](https://togithub.com/googleapis/google-api-java-client/issues/2108)) ([570a162](https://togithub.com/googleapis/google-api-java-client/commit/570a1625fbb3806961d328d90d784b5f0ed21a0c))
* **deps:** Update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.10 ([#2174](https://togithub.com/googleapis/google-api-java-client/issues/2174)) ([9077b4a](https://togithub.com/googleapis/google-api-java-client/commit/9077b4ae4c4214cb0fdcb5248f8c7ecbeb51d27f))
* **deps:** Update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.6 ([#2124](https://togithub.com/googleapis/google-api-java-client/issues/2124)) ([51adc54](https://togithub.com/googleapis/google-api-java-client/commit/51adc541819284dabcdefef39fa39b4a0bd13f6a))
* **deps:** Update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.7 ([#2131](https://togithub.com/googleapis/google-api-java-client/issues/2131)) ([6892bb2](https://togithub.com/googleapis/google-api-java-client/commit/6892bb293ca578b793fe0024c884b21e675abd45))
* **deps:** Update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.8 ([#2140](https://togithub.com/googleapis/google-api-java-client/issues/2140)) ([bb6f19c](https://togithub.com/googleapis/google-api-java-client/commit/bb6f19ce2a89f6d419c908eff7faa944ea74799e))
* **deps:** Update dependency com.google.cloud:libraries-bom to v26.1.0 ([#2126](https://togithub.com/googleapis/google-api-java-client/issues/2126)) ([3d0e0ff](https://togithub.com/googleapis/google-api-java-client/commit/3d0e0ff57cde5ca9eb56e5266dc5c37f3777179d))
* **deps:** Update dependency com.google.cloud:libraries-bom to v26.1.1 ([#2134](https://togithub.com/googleapis/google-api-java-client/issues/2134)) ([15ce062](https://togithub.com/googleapis/google-api-java-client/commit/15ce06244a06b64545f145a2ebdfb62863fcbad4))
* **deps:** Update dependency com.google.cloud:libraries-bom to v26.1.2 ([#2143](https://togithub.com/googleapis/google-api-java-client/issues/2143)) ([da2f6f3](https://togithub.com/googleapis/google-api-java-client/commit/da2f6f3e4645ff3b84465943833404526077ad20))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

blakeli0 pushed a commit that referenced this pull request


          fix: add error description to batch emptiness validation (#2109)

e811a0d

When invoking BatchRequest#execute(), we ensure the batch contains at
least one request to process. Previously this check, did not provide any
error message. Now, if the check fails "Batch is empty" will be the
message of the resulting exception.

Related to googleapis/java-storage#694

blakeli0 pushed a commit that referenced this pull request


          chore(main): release 2.0.1 (#2111)

0d5e7b3

🤖 I have created a release *beep* *boop*
---


## [2.0.1](https://togithub.com/googleapis/google-api-java-client/compare/v2.0.0...v2.0.1) (2022-11-05)


### Bug Fixes

* Add error description to batch emptiness validation ([#2109](https://togithub.com/googleapis/google-api-java-client/issues/2109)) ([2668dd1](https://togithub.com/googleapis/google-api-java-client/commit/2668dd1348e7710a83e008b1e2b2ff6fceedfedf))
* **deps:** Update dependency com.google.api-client:google-api-client to v2 ([#2108](https://togithub.com/googleapis/google-api-java-client/issues/2108)) ([570a162](https://togithub.com/googleapis/google-api-java-client/commit/570a1625fbb3806961d328d90d784b5f0ed21a0c))
* **deps:** Update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.10 ([#2174](https://togithub.com/googleapis/google-api-java-client/issues/2174)) ([9077b4a](https://togithub.com/googleapis/google-api-java-client/commit/9077b4ae4c4214cb0fdcb5248f8c7ecbeb51d27f))
* **deps:** Update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.6 ([#2124](https://togithub.com/googleapis/google-api-java-client/issues/2124)) ([51adc54](https://togithub.com/googleapis/google-api-java-client/commit/51adc541819284dabcdefef39fa39b4a0bd13f6a))
* **deps:** Update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.7 ([#2131](https://togithub.com/googleapis/google-api-java-client/issues/2131)) ([6892bb2](https://togithub.com/googleapis/google-api-java-client/commit/6892bb293ca578b793fe0024c884b21e675abd45))
* **deps:** Update dependency com.google.appengine:appengine-api-1.0-sdk to v2.0.8 ([#2140](https://togithub.com/googleapis/google-api-java-client/issues/2140)) ([bb6f19c](https://togithub.com/googleapis/google-api-java-client/commit/bb6f19ce2a89f6d419c908eff7faa944ea74799e))
* **deps:** Update dependency com.google.cloud:libraries-bom to v26.1.0 ([#2126](https://togithub.com/googleapis/google-api-java-client/issues/2126)) ([3d0e0ff](https://togithub.com/googleapis/google-api-java-client/commit/3d0e0ff57cde5ca9eb56e5266dc5c37f3777179d))
* **deps:** Update dependency com.google.cloud:libraries-bom to v26.1.1 ([#2134](https://togithub.com/googleapis/google-api-java-client/issues/2134)) ([15ce062](https://togithub.com/googleapis/google-api-java-client/commit/15ce06244a06b64545f145a2ebdfb62863fcbad4))
* **deps:** Update dependency com.google.cloud:libraries-bom to v26.1.2 ([#2143](https://togithub.com/googleapis/google-api-java-client/issues/2143)) ([da2f6f3](https://togithub.com/googleapis/google-api-java-client/commit/da2f6f3e4645ff3b84465943833404526077ad20))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment