Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update dependencies #1145

Merged
merged 2 commits into from May 3, 2018
Merged

chore: update dependencies #1145

merged 2 commits into from May 3, 2018

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@JustinBeckwith JustinBeckwith requested review from alexander-fenster and a team May 3, 2018 17:15
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 3, 2018
ofrobots
ofrobots reviewed May 3, 2018
View reviewed changes
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the commit message, but can you change it to something more descriptive of what is being done. chore: update dependencies.

LGTM once you do that.

@JustinBeckwith JustinBeckwith changed the title chore: update all the things chore: update dependencies May 3, 2018
@JustinBeckwith JustinBeckwith merged commit f9c9c3a into googleapis:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrobots ofrobots ofrobots left review comments

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JustinBeckwith @ofrobots @alexander-fenster @googlebot