Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore package-lock.json #1278

Merged
merged 2 commits into from Aug 7, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 0 additions & 14 deletions .circleci/config.yml
@@ -1,22 +1,9 @@
---
# "Include" for unit tests definition.

remove_package_lock: &remove_package_lock
name: Remove package-lock.json if needed.
command: |
WORKFLOW_NAME=`python .circleci/get_workflow_name.py`
echo "Workflow name: $WORKFLOW_NAME"
if [ "$WORKFLOW_NAME" = "nightly" ]; then
echo "Nightly build detected, removing package-lock.json"
rm -f package-lock.json
else
echo "Not a nightly build, skipping this step."
fi

unit_tests: &unit_tests
steps:
- checkout
- run: *remove_package_lock
- run: npm install
- run: npm test
- run:
Expand All @@ -32,7 +19,6 @@ unit_tests: &unit_tests
test_samples: &test_samples
steps:
- checkout
- run: *remove_package_lock
- run: npm install
- run: mkdir ~/.npm-packages
- run: echo "prefix = $HOME/.npm-packages" >> ~/.npmrc
Expand Down
79 changes: 0 additions & 79 deletions .circleci/get_workflow_name.py

This file was deleted.

2 changes: 1 addition & 1 deletion .gitignore
Expand Up @@ -9,4 +9,4 @@ npm-debug.log
.DS_Store
samples/*.keys.json
samples/**/credentials.json

package-lock.json