Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(samples): fix url parsing in sampleClient #1462

Merged
merged 1 commit into from Nov 27, 2018
Merged

fix(samples): fix url parsing in sampleClient #1462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion samples/oauth2.js
View file
Open in desktop
Expand Up @@ -60,7 +60,8 @@ async function authenticate(scopes) {
.createServer(async (req, res) => {
try {
if (req.url.indexOf('/oauth2callback') > -1) {
const qs = new url.URL(req.url).searchParams;
const qs = new url.URL(req.url, 'http://localhost:3000')
.searchParams;
res.end('Authentication successful! Please return to the console.');
server.destroy();
const {tokens} = await oauth2Client.getToken(qs.get('code'));
Expand Down
3 changes: 2 additions & 1 deletion samples/sampleclient.js
View file
Open in desktop
Expand Up @@ -85,7 +85,8 @@ class SampleClient {
.createServer(async (req, res) => {
try {
if (req.url.indexOf('/oauth2callback') > -1) {
const qs = new url.URL(req.url).searchParams;
const qs = new url.URL(req.url, 'http://localhost:3000')
.searchParams;
res.end(
'Authentication successful! Please return to the console.'
);
Expand Down