Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect . in api versions (fix adsense API) #1573

Merged
merged 8 commits into from Feb 2, 2019
Merged

fix: respect . in api versions (fix adsense API) #1573

merged 8 commits into from Feb 2, 2019

Conversation

AVaksman
Copy link
Contributor

Fixes #1531

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2019
JustinBeckwith
JustinBeckwith suggested changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Good fix. Small nit :)

test/test.adsense.ts Outdated Show resolved Hide resolved
@JustinBeckwith JustinBeckwith changed the title Fix adsense initialization fix: respect . in api versions (fix adsense API) Jan 31, 2019
@JustinBeckwith JustinBeckwith added the automerge Merge the pull request once unit tests and other checks pass. label Jan 31, 2019
@AVaksman
Copy link
Contributor Author

I can't see details on why the test failed.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2019
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2019
@JustinBeckwith JustinBeckwith merged commit 45ed202 into googleapis:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AVaksman @JustinBeckwith @googlebot @kokoro-team