Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move context from namespace to class scope #1605

Closed
wants to merge 6 commits into from

Conversation

ajaaym
Copy link
Contributor

@ajaaym ajaaym commented Feb 19, 2019

Fixes #1594 Moving context variable from namespace to class scope.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2019
@ajaaym ajaaym requested a review from a team February 19, 2019 20:12
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #1605 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1605      +/-   ##
==========================================
- Coverage   98.44%   98.43%   -0.02%     
==========================================
  Files           2        2              
  Lines         258      256       -2     
  Branches        2        2              
==========================================
- Hits          254      252       -2     
  Misses          4        4
Impacted Files Coverage Δ
src/index.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16cf464...5327df0. Read the comment docs.

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Have you run the generator, and verified the resulting changes? Could you do that, and add the results as a follow-up commit?

@ajaaym
Copy link
Contributor Author

ajaaym commented Feb 20, 2019

@JustinBeckwith updated PR with generated files.

@JustinBeckwith JustinBeckwith changed the title Fix #1594 move context from namespace to class scope fix: move context from namespace to class scope Feb 26, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 27, 2019
@JustinBeckwith
Copy link
Contributor

superseded by #1660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants