Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose cloudcommerceprocurement api #3331

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LiKang6688
Copy link

@LiKang6688 LiKang6688 commented Aug 31, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<3330> 馃

@google-cla
Copy link

google-cla bot commented Aug 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Aug 31, 2023
@LiKang6688 LiKang6688 marked this pull request as ready for review August 31, 2023 07:25
@LiKang6688 LiKang6688 requested a review from a team as a code owner August 31, 2023 07:25
@gavinsharp
Copy link

Hi @LiKang6688 @danieljbruce, any chance this could get merged? This API being exposed would be helpful.

Copy link

@daniel-bcw daniel-bcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants