Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't set http.redirect_codes if the attr doesn't exist #841

Merged
merged 7 commits into from Mar 13, 2020

Conversation

busunkim96
Copy link
Contributor

This allows folks who can't upgrade their httplib2 version to use the latest version of the library. Note that it is still strongly recommended that you upgrade (see install_requires).

@aaltay is there an issue tracking the httplib2 upgrade I can link to? I'd like this to be removed eventually.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2020
@aaltay
Copy link

aaltay commented Mar 12, 2020

Could we also change install requires to be similar to before like: "httplib2>=0.9.2,<1dev". Because, now with this change the library will be backward compatible, and it will not cause force upgrades of httplib2 library. (force upgrades also cause issues.) ?

@busunkim96
Copy link
Contributor Author

Made the change to setup.py.

Is it possible for your tests to pin to an older version of this library until you're able to sort out upgrading httplib2? Or is there a requirement for you to always be testing with the latest version of google-api-python-client?

@aaltay
Copy link

aaltay commented Mar 12, 2020

Made the change to setup.py.

Is it possible for your tests to pin to an older version of this library until you're able to sort out upgrading httplib2? Or is there a requirement for you to always be testing with the latest version of google-api-python-client?

I don't there is a requirement to use at head. This is our setup file (https://github.com/apache/beam/blob/master/sdks/python/setup.py) -- I cannot find a direct dependency. Probably there is some indirect dependency.

setup.py Show resolved Hide resolved
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Mar 13, 2020
setup.py Show resolved Hide resolved
@busunkim96 busunkim96 merged commit a480d53 into googleapis:master Mar 13, 2020
@aaltay
Copy link

aaltay commented Mar 13, 2020

Thank you all! When would this change be available in pypi?

@busunkim96
Copy link
Contributor Author

Just looking for an approval on the release PR(#842) and then I'll push it out to PyPI. :)

@busunkim96
Copy link
Contributor Author

@aaltay
Copy link

aaltay commented Mar 13, 2020

1.8.0 is released @aaltay https://pypi.org/project/google-api-python-client/1.8.0/

Thank you very much for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants