Skip to content

Commit

Permalink
chore: using full package names to avoid incorrect import merge (#1193)
Browse files Browse the repository at this point in the history
* fix bogus import error by changing import order

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* exclude ExternalAccount from owl bot

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* disable import order

* change imports again

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* disabling owl bot

* moving import

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* removing owlbot lock file to disable it

* Revert "removing owlbot lock file to disable it"

This reverts commit 59cb9a7.

* Revert "disabling owl bot"

This reverts commit 5498061.

* re-enable owlbot and revert poc config changes

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
TimurSadykov and gcf-owl-bot[bot] committed Apr 7, 2023
1 parent 51fd1fa commit c52ecaf
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 6 deletions.
16 changes: 16 additions & 0 deletions .github/.OwlBot.yaml
@@ -0,0 +1,16 @@
# Copyright 2021 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

docker:
image: "gcr.io/cloud-devrel-public-resources/owlbot-java:latest"
Expand Up @@ -43,7 +43,6 @@
import com.google.common.base.MoreObjects;
import java.io.IOException;
import java.io.InputStream;
import java.io.Serializable;
import java.math.BigDecimal;
import java.net.URI;
import java.nio.charset.StandardCharsets;
Expand All @@ -69,7 +68,7 @@ public abstract class ExternalAccountCredentials extends GoogleCredentials {
private static final long serialVersionUID = 8049126194174465023L;

/** Base credential source class. Dictates the retrieval method of the external credential. */
abstract static class CredentialSource implements Serializable {
abstract static class CredentialSource implements java.io.Serializable {

private static final long serialVersionUID = 8204657811562399944L;

Expand Down Expand Up @@ -641,7 +640,7 @@ private static boolean isValidUrl(String url) {
* }
* </pre>
*/
static final class ServiceAccountImpersonationOptions implements Serializable {
static final class ServiceAccountImpersonationOptions implements java.io.Serializable {

private static final long serialVersionUID = 4250771921886280953L;
private static final int DEFAULT_TOKEN_LIFETIME_SECONDS = 3600;
Expand Down
3 changes: 1 addition & 2 deletions owlbot.py
Expand Up @@ -36,7 +36,6 @@
".kokoro/nightly/integration.cfg",
".kokoro/presubmit/integration.cfg",
".kokoro/presubmit/graalvm-native.cfg",
".kokoro/presubmit/graalvm-native-17.cfg",
"oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java"
".kokoro/presubmit/graalvm-native-17.cfg"
]
)
1 change: 0 additions & 1 deletion pom.xml
Expand Up @@ -214,7 +214,6 @@
<version>2.13</version>
<configuration>
<verbose>true</verbose>
<skipSortingImports>true</skipSortingImports>
</configuration>
</plugin>
<plugin>
Expand Down

0 comments on commit c52ecaf

Please sign in to comment.