Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(samples): modified comments in the samples and minor refactor #990

Merged
merged 4 commits into from Sep 13, 2022
Merged

docs(samples): modified comments in the samples and minor refactor #990

merged 4 commits into from Sep 13, 2022

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Aug 29, 2022 •
edited

Changes:

  1. Modified Auth implicit sample to use GCS instead of GCE.
  2. Modified comments
  3. Minor variable value refactoring

@Sita04 Sita04 requested a review from a team as a code owner August 29, 2022 08:20
@product-auto-label product-auto-label bot added size: m Pull request size is medium. samples Issues that are directly related to samples. labels Aug 29, 2022
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2022
@Sita04 Sita04 requested a review from piaxc August 30, 2022 07:56
piaxc
piaxc approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@piaxc piaxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sita!

@lesv lesv merged commit 669ab04 into main Sep 13, 2022
@lesv lesv deleted the patch-auth-samples branch September 13, 2022 22:42
@release-please release-please bot mentioned this pull request Oct 10, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 17, 2022
@release-please
chore(main): release 1.12.0 (#1050)
fda7fa4 
🤖 I have created a release *beep* *boop*
---


## [1.12.0](https://togithub.com/googleapis/google-auth-library-java/compare/v1.11.0...v1.12.0) (2022-10-14)


### Features

* Adding validation for psc endpoints ([#1042](https://togithub.com/googleapis/google-auth-library-java/issues/1042)) ([b37a565](https://togithub.com/googleapis/google-auth-library-java/commit/b37a565c6c1e7acb44baf2307c862c9df8be9345))


### Bug Fixes

* Fixed javadoc errors ([#945](https://togithub.com/googleapis/google-auth-library-java/issues/945)) ([1ddc994](https://togithub.com/googleapis/google-auth-library-java/commit/1ddc99481ae8b0f0eceb4cb442d5c6614ec8a411))


### Documentation

* **samples:** Modified comments in the samples and minor refactor ([#990](https://togithub.com/googleapis/google-auth-library-java/issues/990)) ([669ab04](https://togithub.com/googleapis/google-auth-library-java/commit/669ab042844e46d0503bbd31fd2da92a7963bad5))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@piaxc piaxc piaxc approved these changes

Assignees

@lesv lesv

Labels
samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sita04 @lesv @piaxc @kokoro-team