New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: expiration time of the ImpersonatedCredentials token depending on the current host's timezone #932
Merged
gcf-merge-on-green
merged 10 commits into
googleapis:main
from
ivan-f-n:impersonated-creds-date-parsing
Aug 2, 2022
Merged
fix: expiration time of the ImpersonatedCredentials token depending on the current host's timezone #932
gcf-merge-on-green
merged 10 commits into
googleapis:main
from
ivan-f-n:impersonated-creds-date-parsing
Aug 2, 2022
Commits on Jul 14, 2022
-
fix: refreshAccessToken method of ImpersonatedCredentials class now o…
…btains the given expiration time date's timezone correctly instead of using local timezone
Configuration menu - View commit details
-
Copy full SHA for 50d3a5c - Browse repository at this point
Copy the full SHA 50d3a5cView commit details -
Fix bug in ImpersonatedCredentials class where the date received as e…
…xpirationTime was being incorrectly parsed, assuming the date was in the default JVM timezone instead of reading from the date string what timezone it was.
Configuration menu - View commit details
-
Copy full SHA for 8ad0f77 - Browse repository at this point
Copy the full SHA 8ad0f77View commit details -
Configuration menu - View commit details
-
Copy full SHA for bafd0ac - Browse repository at this point
Copy the full SHA bafd0acView commit details -
Configuration menu - View commit details
-
Copy full SHA for d85d431 - Browse repository at this point
Copy the full SHA d85d431View commit details -
test: tests now change the timezone of the calendar used when parsing…
… the date instead of returning dates in different timezones Expose to tests the calendar object used by the SimpleDateFormat object of the refreshAccessToken method in the ImpersonatedCredentials class That way we stop relying on returning dates in different timezones in the expireTime returned by the mockTransportFactory
Configuration menu - View commit details
-
Copy full SHA for 3576e93 - Browse repository at this point
Copy the full SHA 3576e93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e12ce8 - Browse repository at this point
Copy the full SHA 4e12ce8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a6937c - Browse repository at this point
Copy the full SHA 5a6937cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62d7b08 - Browse repository at this point
Copy the full SHA 62d7b08View commit details
Commits on Jul 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 98c1516 - Browse repository at this point
Copy the full SHA 98c1516View commit details
Commits on Aug 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 76aa904 - Browse repository at this point
Copy the full SHA 76aa904View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.