chore(deps)!: upgrade node-gtoken to 7.0.0 (#1590)

* chore(deps): upgrade node-gtoken to 7.0.0 * fix!: remove p12 functionality for auth * revert * chore: remove tests
googleapis · Jul 12, 2023 · 8738df9 · 8738df9
1 parent 1bf3376
commit 8738df9
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 65 deletions.
diff --git a/package.json b/package.json
@@ -21,7 +21,7 @@
     "ecdsa-sig-formatter": "^1.0.11",
     "gaxios": "^5.0.0",
     "gcp-metadata": "^5.3.0",
-    "gtoken": "^6.1.0",
+    "gtoken": "^7.0.0",
     "jws": "^4.0.0",
     "lru-cache": "^6.0.0"
   },

diff --git a/test/test.googleauth.ts b/test/test.googleauth.ts
@@ -2544,25 +2544,6 @@ describe('googleauth', () => {
     scope.done();
     assert.strictEqual('http://foo', (jwt as JWT).gtoken!.scope);
   });
-  it('allows client to be instantiated from p12 key file', async () => {
-    const auth = new GoogleAuth({
-      keyFile: P12_PATH,
-      clientOptions: {
-        scopes: 'http://foo',
-        email: 'foo@serviceaccount.com',
-        subject: 'bar@subjectaccount.com',
-      },
-    });
-    const jwt = await auth.getClient();
-    const scope = createGTokenMock({access_token: 'initial-access-token'});
-    const headers = await jwt.getRequestHeaders();
-    assert.deepStrictEqual(
-      headers.Authorization,
-      'Bearer initial-access-token'
-    );
-    scope.done();
-    assert.strictEqual('http://foo', (jwt as JWT).gtoken!.scope);
-  });
 
   // Allows a client to be instantiated from a certificate,
   // See: https://github.com/googleapis/google-auth-library-nodejs/issues/808
@@ -2585,25 +2566,6 @@ describe('googleauth', () => {
     scope.done();
     assert.strictEqual('http://foo', (jwt as JWT).gtoken!.scope);
   });
-  it('allows client to be instantiated from p12 key file', async () => {
-    const auth = new GoogleAuth({
-      keyFile: P12_PATH,
-      clientOptions: {
-        scopes: 'http://foo',
-        email: 'foo@serviceaccount.com',
-        subject: 'bar@subjectaccount.com',
-      },
-    });
-    const jwt = await auth.getClient();
-    const scope = createGTokenMock({access_token: 'initial-access-token'});
-    const headers = await jwt.getRequestHeaders();
-    assert.deepStrictEqual(
-      headers.Authorization,
-      'Bearer initial-access-token'
-    );
-    scope.done();
-    assert.strictEqual('http://foo', (jwt as JWT).gtoken!.scope);
-  });
 
   // Allows a client to be instantiated from a certificate,
   // See: https://github.com/googleapis/google-auth-library-nodejs/issues/808
@@ -2626,23 +2588,4 @@ describe('googleauth', () => {
     scope.done();
     assert.strictEqual('http://foo', (jwt as JWT).gtoken!.scope);
   });
-  it('allows client to be instantiated from p12 key file', async () => {
-    const auth = new GoogleAuth({
-      keyFile: P12_PATH,
-      clientOptions: {
-        scopes: 'http://foo',
-        email: 'foo@serviceaccount.com',
-        subject: 'bar@subjectaccount.com',
-      },
-    });
-    const jwt = await auth.getClient();
-    const scope = createGTokenMock({access_token: 'initial-access-token'});
-    const headers = await jwt.getRequestHeaders();
-    assert.deepStrictEqual(
-      headers.Authorization,
-      'Bearer initial-access-token'
-    );
-    scope.done();
-    assert.strictEqual('http://foo', (jwt as JWT).gtoken!.scope);
-  });
 });
diff --git a/test/test.jwt.ts b/test/test.jwt.ts
@@ -721,13 +721,6 @@ describe('jwt', () => {
     assert.strictEqual(private_key, PEM_CONTENTS);
   });
 
-  it('getCredentials should handle a p12 keyFile', async () => {
-    const jwt = new JWT({keyFile: P12_PATH});
-    const {private_key, client_email} = await jwt.getCredentials();
-    assert(private_key);
-    assert.strictEqual(client_email, undefined);
-  });
-
   it('getCredentials should handle a json keyFile', async () => {
     const jwt = new JWT();
     jwt.fromJSON(json);