feat: Enable Auth Observability Metrics #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add getVersion functionality. * Add unit test for it.
* With empty metrics headers
1) Simplify token endpoint metrics header getter logic 2) Update documentation 3) Add explaination to the tests.
bshaffer
added
the
do not merge
|
Added "Do Not Merge" as we are waiting on @yash30201 to confirm that the metrics are available on the backend as expected. |
|
Confirmed that metrics are available for Service API token usage on backend and using this PR's version of google-auth-library-php populates the metrics table properly. 🚀 There's still some problem on backend with metrics availability in token endpoint request to cc: @bshaffer |
yash30201
removed
the
do not merge
bshaffer
reviewed
Apr 30, 2024
yash30201
force-pushed
the
metrics-with-trait
branch
from
577799f
to
e71c48e
Compare
bshaffer
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go/php-auth-metrics-design-doc
Status