fix: fix socket leak in impersonated_credentials (#1123)

* fix: Fix socket leak in impersonated_credentials impersonated_credentials.Credentials.sign_bytes() created a session that wasn't closed leaking a socket. This fixes the issue by always closing the requests session after a signing request is complete. Fixes #1122
googleapis · Aug 29, 2022 · b1eb467 · b1eb467
1 parent bb5c979
commit b1eb467
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/google/auth/impersonated_credentials.py b/google/auth/impersonated_credentials.py
@@ -288,9 +288,12 @@ def sign_bytes(self, message):
 
         authed_session = AuthorizedSession(self._source_credentials)
 
-        response = authed_session.post(
-            url=iam_sign_endpoint, headers=headers, json=body
-        )
+        try:
+            response = authed_session.post(
+                url=iam_sign_endpoint, headers=headers, json=body
+            )
+        finally:
+            authed_session.close()
 
         if response.status_code != http_client.OK:
             raise exceptions.TransportError(

diff --git a/system_tests/secrets.tar.enc b/system_tests/secrets.tar.enc