chore: Update GAX dependencies for *all* libraries. #11581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we don't have to manually update GAX to get the newest common protos.
1 task
|
Yes, the possibility of a patch is the reason for pinning common versions - but I agree, it hardly ever happens. Let's do this for now, but consider removing the current logic that prevents defaulting for stable versions. |
jskeet
approved these changes
Jan 24, 2024
Yep, makes sense, I've created an internal issue for that. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we don't have to manually update GAX to get the newest common protos?
@jskeet I've updated dependencies un apis.json and regenerated all projects (by running release manager's update-dependencies). I believe you only ran regenerate-projects which updates dependencies for alphas and betas only.
I understand you may have done that on purpose so let's chat about it. I figure we so rarely release a patch that we can assume that the next release of each library will be a minor.
Once this is in, #11580 and any others like it will be OK.