feat: [Google.Cloud.Spanner.V1] add `RESOURCE_EXHAUSTED` to the list of retryable error codes #12650

gcf-owl-bot · 2024-04-26T06:07:57Z

Regenerate this pull request now.

PiperOrigin-RevId: 628281023

Source-Link: googleapis/googleapis@60536a2

Source-Link: https://github.com/googleapis/googleapis-gen/commit/c5cfd5b956f9eadff54096c9f1c8a57ab01db294
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuU3Bhbm5lci5WMS8uT3dsQm90LnlhbWwiLCJoIjoiYzVjZmQ1Yjk1NmY5ZWFkZmY1NDA5NmM5ZjFjOGE1N2FiMDFkYjI5NCJ9

github-actions · 2024-04-26T06:08:51Z

Pull request diff results
OwlBot post-processor has not run: failing diff.

jskeet · 2024-04-26T06:54:14Z

Not sure why the OwlBot post-processor still hasn't finished... will give it a bit longer before manually kicking it off.

gcf-owl-bot · 2024-04-26T16:51:01Z

Owl bot is regenerating pull request 12650...
Build name: YTBkYzYxYjYtZjVhMC00YTZmLTkwYzMtNWU4ZTVlNjM0NjI4

github-actions · 2024-04-26T17:02:25Z

Pull request diff results
OwlBot post-processor has not run: failing diff.

gcf-owl-bot · 2024-04-29T17:11:44Z

Owl bot is regenerating pull request 12650...
Build name: MThmZTBhOTAtNzkwNC00MGMzLTkxN2ItODkwNmFkY2FmNzI2

jskeet · 2024-04-29T17:11:55Z

(Clicked on the regeneration button to see if the post-processor will run now...)

github-actions · 2024-04-29T17:24:16Z

Pull request diff results
OwlBot post-processor has not run: failing diff.

jskeet · 2024-04-29T17:28:45Z

I'll look into the post-processor failure tomorrow.

jskeet · 2024-04-30T05:57:53Z

Failure part of the log:

Step #5: Failed: System.IO.DirectoryNotFoundException: Could not find a part of the path '/workspace/google-cloud-dotnet/tmp'.
Step #5:    at System.IO.FileSystem.RemoveDirectory(String fullPath, Boolean recursive)
Step #5:    at System.IO.Directory.Delete(String path, Boolean recursive)
Step #5:    at Google.Cloud.Tools.ReleaseManager.GenerateApisCommand.Execute(String[] args) in /workspace/google-cloud-dotnet/tools/Google.Cloud.Tools.ReleaseManager/GenerateApisCommand.cs:line 85
Step #5:    at Google.Cloud.Tools.ReleaseManager.Program.Main(String[] args) in /workspace/google-cloud-dotnet/tools/Google.Cloud.Tools.ReleaseManager/Program.cs:line 39

Should be easy enough to fix.

github-actions · 2024-04-30T15:44:47Z

Pull request diff results
OwlBot post-processor has not run: failing diff.

PiperOrigin-RevId: 628281023 Source-Link: googleapis/googleapis@60536a2 Source-Link: googleapis/googleapis-gen@c5cfd5b Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuU3Bhbm5lci5WMS8uT3dsQm90LnlhbWwiLCJoIjoiYzVjZmQ1Yjk1NmY5ZWFkZmY1NDA5NmM5ZjFjOGE1N2FiMDFkYjI5NCJ9

github-actions · 2024-04-30T15:50:26Z

Pull request diff results
Finding changes in Google.Cloud.Spanner.V1...
Comparing old and new versions (by source)
Diff level: Identical

Comparing with previous NuGet package
Checking compatibility for Google.Cloud.Spanner.V1 version 5.0.0-beta03
Differences from 4.6.0
Major changes:
Class 'PooledSession'; method 'Task WithFreshTransactionOrNewAsync(TransactionOptions transactionOptions, CancellationToken cancellationToken)' removed.
Class 'SessionPool'; method 'SessionPool.DatabaseStatistics GetStatisticsSnapshot(DatabaseName databaseName)' removed.
Class 'SessionPool.DatabaseStatistics' removed.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int32 ReadPoolCount { get; }' removed.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int32 ReadWritePoolCount { get; }' removed.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int64 ReadWriteTransactionRequests { get; }' removed.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int64 ReadWriteTransactionRequestsPrewarmed { get; }' removed.
Class 'SessionPool.Statistics'; property 'IReadOnlyList<SessionPool.DatabaseStatistics> PerDatabaseStatistics { get; }' removed.
Class 'SessionPool.Statistics'; property 'Int32 TotalReadPoolCount { get; }' removed.
Class 'SessionPool.Statistics'; property 'Int32 TotalReadWritePoolCount { get; }' removed.
Class 'SessionPoolOptions'; property 'Double WriteSessionsFraction { get; set; }' removed.

Minor changes:
Class 'BatchWriteRequest' added.
Class 'BatchWriteRequest.Types' added.
Class 'BatchWriteRequest.Types.MutationGroup' added.
Class 'BatchWriteResponse' added.
Class 'CommitRequest'; property 'Duration MaxCommitDelay { get; set; }' added.
Class 'CommitRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.CommitRequest::MaxCommitDelayFieldNumber' added.
Class 'DirectedReadOptions' added.
Enum 'DirectedReadOptions.ReplicasOneofCase' added.
Class 'DirectedReadOptions.Types' added.
Class 'DirectedReadOptions.Types.ExcludeReplicas' added.
Class 'DirectedReadOptions.Types.IncludeReplicas' added.
Class 'DirectedReadOptions.Types.ReplicaSelection' added.
Class 'DirectedReadOptions.Types.ReplicaSelection.Types' added.
Enum 'DirectedReadOptions.Types.ReplicaSelection.Types.Type' added.
Class 'ExecuteSqlRequest'; property 'DirectedReadOptions DirectedReadOptions { get; set; }' added.
Class 'ExecuteSqlRequest'; property 'TransactionSelector Transaction { get; set; }' modifers changed from '' to 'sealed virtual'.
Class 'ExecuteSqlRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.ExecuteSqlRequest::DirectedReadOptionsFieldNumber' added.
Class 'PartitionQueryRequest'; property 'TransactionSelector Transaction { get; set; }' modifers changed from '' to 'sealed virtual'.
Class 'PartitionReadOrQueryRequest'; property 'TransactionSelector Transaction { set; }' getter access modifer changed from '' to 'public'.
Class 'PartitionReadRequest'; property 'TransactionSelector Transaction { get; set; }' modifers changed from '' to 'sealed virtual'.
Class 'PooledSession'; method 'Task RefreshedOrNewAsync(CancellationToken cancellationToken)' added.
Class 'ReadOrQueryRequest'; property 'DirectedReadOptions DirectedReadOptions { get; set; }' added.
Class 'ReadOrQueryRequest'; property 'TransactionSelector Transaction { set; }' getter access modifer changed from '' to 'public'.
Class 'ReadRequest'; property 'DirectedReadOptions DirectedReadOptions { get; set; }' added.
Class 'ReadRequest'; property 'TransactionSelector Transaction { get; set; }' modifers changed from '' to 'sealed virtual'.
Class 'ReadRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.ReadRequest::DirectedReadOptionsFieldNumber' added.
Class 'Session'; property 'Boolean Multiplexed { get; set; }' added.
Class 'Session'; constant 'System.Int32 Google.Cloud.Spanner.V1.Session::MultiplexedFieldNumber' added.
Class 'SessionPool'; method 'Task AcquireSessionAsync(SessionPool.SessionPoolSegmentKey key, TransactionOptions transactionOptions, Boolean singleUseTransaction, CancellationToken cancellationToken)' added.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int32 PoolCount { get; }' added.
Class 'SessionPool.Statistics'; property 'Int32 TotalPoolCount { get; }' added.
Class 'Spanner.SpannerBase'; method 'Task BatchWrite(BatchWriteRequest request, IServerStreamWriter responseStream, ServerCallContext context)' added.
Class 'Spanner.SpannerClient'; method 'AsyncServerStreamingCall BatchWrite(BatchWriteRequest request, CallOptions options)' added.
Class 'Spanner.SpannerClient'; method 'AsyncServerStreamingCall BatchWrite(BatchWriteRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'SpannerClient'; method 'SpannerClient.BatchWriteStream BatchWrite(BatchWriteRequest request, CallSettings callSettings = null)' added.
Class 'SpannerClient'; method 'SpannerClient.BatchWriteStream BatchWrite(SessionName session, IEnumerable<BatchWriteRequest.Types.MutationGroup> mutationGroups, CallSettings callSettings = null)' added.
Class 'SpannerClient'; method 'SpannerClient.BatchWriteStream BatchWrite(String session, IEnumerable<BatchWriteRequest.Types.MutationGroup> mutationGroups, CallSettings callSettings = null)' added.
Class 'SpannerClient.BatchWriteStream' added.
Class 'SpannerClientBuilder'; property 'DirectedReadOptions DirectedReadOptions { get; set; }' added.
Class 'SpannerClientBuilder'; property 'Boolean LeaderRoutingEnabled { get; set; }' added.
Class 'SpannerClientImpl'; method 'SpannerClient.BatchWriteStream BatchWrite(BatchWriteRequest request, CallSettings callSettings = null)' added.
Class 'SpannerSettings'; property 'CallSettings BatchWriteSettings { get; set; }' added.
Class 'TransactionOptions'; property 'Boolean ExcludeTxnFromChangeStreams { get; set; }' added.
Class 'TransactionOptions'; constant 'System.Int32 Google.Cloud.Spanner.V1.TransactionOptions::ExcludeTxnFromChangeStreamsFieldNumber' added.
Class 'Type'; property 'String ProtoTypeFqn { get; set; }' added.
Class 'Type'; constant 'System.Int32 Google.Cloud.Spanner.V1.Type::ProtoTypeFqnFieldNumber' added.
Enum 'TypeAnnotationCode' entry 'PgOid' added.
Enum 'TypeCode' entry 'Enum' added.
Enum 'TypeCode' entry 'Float32' added.
Enum 'TypeCode' entry 'Proto' added.
Class 'ServiceCollectionExtensions'; method 'IServiceCollection AddSpannerClient(IServiceCollection services, Action<IServiceProvider, SpannerClientBuilder> action)' added.

Diff level: Major

Differences from 5.0.0-beta03
Minor changes:
Class 'ServiceCollectionExtensions'; method 'IServiceCollection AddSpannerClient(IServiceCollection services, Action<IServiceProvider, SpannerClientBuilder> action)' added.

Diff level: Minor

Finished comparisons for Google.Cloud.Spanner.V1

github-actions · 2024-04-30T15:51:22Z

Pull request diff results
Finding changes in Google.Cloud.Spanner.V1...
Comparing old and new versions (by source)
Diff level: Identical

Comparing with previous NuGet package
Checking compatibility for Google.Cloud.Spanner.V1 version 5.0.0-beta03
Differences from 4.6.0
Major changes:
Class 'PooledSession'; method 'Task WithFreshTransactionOrNewAsync(TransactionOptions transactionOptions, CancellationToken cancellationToken)' removed.
Class 'SessionPool'; method 'SessionPool.DatabaseStatistics GetStatisticsSnapshot(DatabaseName databaseName)' removed.
Class 'SessionPool.DatabaseStatistics' removed.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int32 ReadPoolCount { get; }' removed.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int32 ReadWritePoolCount { get; }' removed.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int64 ReadWriteTransactionRequests { get; }' removed.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int64 ReadWriteTransactionRequestsPrewarmed { get; }' removed.
Class 'SessionPool.Statistics'; property 'IReadOnlyList<SessionPool.DatabaseStatistics> PerDatabaseStatistics { get; }' removed.
Class 'SessionPool.Statistics'; property 'Int32 TotalReadPoolCount { get; }' removed.
Class 'SessionPool.Statistics'; property 'Int32 TotalReadWritePoolCount { get; }' removed.
Class 'SessionPoolOptions'; property 'Double WriteSessionsFraction { get; set; }' removed.

Minor changes:
Class 'BatchWriteRequest' added.
Class 'BatchWriteRequest.Types' added.
Class 'BatchWriteRequest.Types.MutationGroup' added.
Class 'BatchWriteResponse' added.
Class 'CommitRequest'; property 'Duration MaxCommitDelay { get; set; }' added.
Class 'CommitRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.CommitRequest::MaxCommitDelayFieldNumber' added.
Class 'DirectedReadOptions' added.
Enum 'DirectedReadOptions.ReplicasOneofCase' added.
Class 'DirectedReadOptions.Types' added.
Class 'DirectedReadOptions.Types.ExcludeReplicas' added.
Class 'DirectedReadOptions.Types.IncludeReplicas' added.
Class 'DirectedReadOptions.Types.ReplicaSelection' added.
Class 'DirectedReadOptions.Types.ReplicaSelection.Types' added.
Enum 'DirectedReadOptions.Types.ReplicaSelection.Types.Type' added.
Class 'ExecuteSqlRequest'; property 'DirectedReadOptions DirectedReadOptions { get; set; }' added.
Class 'ExecuteSqlRequest'; property 'TransactionSelector Transaction { get; set; }' modifers changed from '' to 'sealed virtual'.
Class 'ExecuteSqlRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.ExecuteSqlRequest::DirectedReadOptionsFieldNumber' added.
Class 'PartitionQueryRequest'; property 'TransactionSelector Transaction { get; set; }' modifers changed from '' to 'sealed virtual'.
Class 'PartitionReadOrQueryRequest'; property 'TransactionSelector Transaction { set; }' getter access modifer changed from '' to 'public'.
Class 'PartitionReadRequest'; property 'TransactionSelector Transaction { get; set; }' modifers changed from '' to 'sealed virtual'.
Class 'PooledSession'; method 'Task RefreshedOrNewAsync(CancellationToken cancellationToken)' added.
Class 'ReadOrQueryRequest'; property 'DirectedReadOptions DirectedReadOptions { get; set; }' added.
Class 'ReadOrQueryRequest'; property 'TransactionSelector Transaction { set; }' getter access modifer changed from '' to 'public'.
Class 'ReadRequest'; property 'DirectedReadOptions DirectedReadOptions { get; set; }' added.
Class 'ReadRequest'; property 'TransactionSelector Transaction { get; set; }' modifers changed from '' to 'sealed virtual'.
Class 'ReadRequest'; constant 'System.Int32 Google.Cloud.Spanner.V1.ReadRequest::DirectedReadOptionsFieldNumber' added.
Class 'Session'; property 'Boolean Multiplexed { get; set; }' added.
Class 'Session'; constant 'System.Int32 Google.Cloud.Spanner.V1.Session::MultiplexedFieldNumber' added.
Class 'SessionPool'; method 'Task AcquireSessionAsync(SessionPool.SessionPoolSegmentKey key, TransactionOptions transactionOptions, Boolean singleUseTransaction, CancellationToken cancellationToken)' added.
Class 'SessionPool.SessionPoolSegmentStatistics'; property 'Int32 PoolCount { get; }' added.
Class 'SessionPool.Statistics'; property 'Int32 TotalPoolCount { get; }' added.
Class 'Spanner.SpannerBase'; method 'Task BatchWrite(BatchWriteRequest request, IServerStreamWriter responseStream, ServerCallContext context)' added.
Class 'Spanner.SpannerClient'; method 'AsyncServerStreamingCall BatchWrite(BatchWriteRequest request, CallOptions options)' added.
Class 'Spanner.SpannerClient'; method 'AsyncServerStreamingCall BatchWrite(BatchWriteRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'SpannerClient'; method 'SpannerClient.BatchWriteStream BatchWrite(BatchWriteRequest request, CallSettings callSettings = null)' added.
Class 'SpannerClient'; method 'SpannerClient.BatchWriteStream BatchWrite(SessionName session, IEnumerable<BatchWriteRequest.Types.MutationGroup> mutationGroups, CallSettings callSettings = null)' added.
Class 'SpannerClient'; method 'SpannerClient.BatchWriteStream BatchWrite(String session, IEnumerable<BatchWriteRequest.Types.MutationGroup> mutationGroups, CallSettings callSettings = null)' added.
Class 'SpannerClient.BatchWriteStream' added.
Class 'SpannerClientBuilder'; property 'DirectedReadOptions DirectedReadOptions { get; set; }' added.
Class 'SpannerClientBuilder'; property 'Boolean LeaderRoutingEnabled { get; set; }' added.
Class 'SpannerClientImpl'; method 'SpannerClient.BatchWriteStream BatchWrite(BatchWriteRequest request, CallSettings callSettings = null)' added.
Class 'SpannerSettings'; property 'CallSettings BatchWriteSettings { get; set; }' added.
Class 'TransactionOptions'; property 'Boolean ExcludeTxnFromChangeStreams { get; set; }' added.
Class 'TransactionOptions'; constant 'System.Int32 Google.Cloud.Spanner.V1.TransactionOptions::ExcludeTxnFromChangeStreamsFieldNumber' added.
Class 'Type'; property 'String ProtoTypeFqn { get; set; }' added.
Class 'Type'; constant 'System.Int32 Google.Cloud.Spanner.V1.Type::ProtoTypeFqnFieldNumber' added.
Enum 'TypeAnnotationCode' entry 'PgOid' added.
Enum 'TypeCode' entry 'Float32' added.
Enum 'TypeCode' entry 'Enum' added.
Enum 'TypeCode' entry 'Proto' added.
Class 'ServiceCollectionExtensions'; method 'IServiceCollection AddSpannerClient(IServiceCollection services, Action<IServiceProvider, SpannerClientBuilder> action)' added.

Diff level: Major

Differences from 5.0.0-beta03
Minor changes:
Class 'ServiceCollectionExtensions'; method 'IServiceCollection AddSpannerClient(IServiceCollection services, Action<IServiceProvider, SpannerClientBuilder> action)' added.

Diff level: Minor

Finished comparisons for Google.Cloud.Spanner.V1

gcf-owl-bot bot added the owl-bot-copy label Apr 26, 2024

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 26, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2024

jskeet added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2024

gcf-owl-bot bot force-pushed the owl-bot-copy-apis-Google_Cloud_Spanner_V1 branch from b2f55bd to 6534cd2 Compare April 26, 2024 17:01

trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2024

gcf-owl-bot bot force-pushed the owl-bot-copy-apis-Google_Cloud_Spanner_V1 branch from 6534cd2 to 44600f7 Compare April 29, 2024 17:23

trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 29, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 29, 2024

jskeet self-assigned this Apr 29, 2024

jskeet force-pushed the owl-bot-copy-apis-Google_Cloud_Spanner_V1 branch from 44600f7 to 47aff5a Compare April 30, 2024 15:43

trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 30, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 30, 2024

jskeet added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 30, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 30, 2024

gcf-owl-bot bot marked this pull request as ready for review April 30, 2024 15:48

gcf-owl-bot bot force-pushed the owl-bot-copy-apis-Google_Cloud_Spanner_V1 branch from 47aff5a to 44ebd40 Compare April 30, 2024 15:48

gcf-owl-bot bot requested review from a team as code owners April 30, 2024 15:48

trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 30, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 30, 2024

gcf-owl-bot bot force-pushed the owl-bot-copy-apis-Google_Cloud_Spanner_V1 branch from 44ebd40 to acd1a45 Compare April 30, 2024 15:49

trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 30, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 30, 2024

jskeet approved these changes Apr 30, 2024

View reviewed changes

jskeet merged commit fbb0099 into main Apr 30, 2024
13 checks passed

jskeet deleted the owl-bot-copy-apis-Google_Cloud_Spanner_V1 branch April 30, 2024 16:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [Google.Cloud.Spanner.V1] add `RESOURCE_EXHAUSTED` to the list of retryable error codes #12650

feat: [Google.Cloud.Spanner.V1] add `RESOURCE_EXHAUSTED` to the list of retryable error codes #12650

gcf-owl-bot bot commented Apr 26, 2024 •

edited

github-actions bot commented Apr 26, 2024

jskeet commented Apr 26, 2024

gcf-owl-bot bot commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

gcf-owl-bot bot commented Apr 29, 2024

jskeet commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

jskeet commented Apr 29, 2024

jskeet commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

feat: [Google.Cloud.Spanner.V1] add RESOURCE_EXHAUSTED to the list of retryable error codes #12650

feat: [Google.Cloud.Spanner.V1] add RESOURCE_EXHAUSTED to the list of retryable error codes #12650

Conversation

gcf-owl-bot bot commented Apr 26, 2024 • edited

github-actions bot commented Apr 26, 2024

jskeet commented Apr 26, 2024

gcf-owl-bot bot commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

gcf-owl-bot bot commented Apr 29, 2024

jskeet commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

jskeet commented Apr 29, 2024

jskeet commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

feat: [Google.Cloud.Spanner.V1] add `RESOURCE_EXHAUSTED` to the list of retryable error codes #12650

feat: [Google.Cloud.Spanner.V1] add `RESOURCE_EXHAUSTED` to the list of retryable error codes #12650

gcf-owl-bot bot commented Apr 26, 2024 •

edited