Skip to content

Commit

Permalink
fix(bigquery/storage/managedwriter): automatic retry for multiplex te…
Browse files Browse the repository at this point in the history
…st (#8601)

In #8599 we caught a flake related to DeadlineExceeded errors.  This
class of error is retryable, so we set the EnableWriteRetries option
when constructing writers to address this.

The DE was likely raised from the service side, as in this case the test
ran for ~32s (deadline is 90) and normal execution time should be
sub-10s.  This is also borne out by the problematic writes, which were
both destined for the same table.

Fixes: #8599
  • Loading branch information
shollyman committed Sep 21, 2023
1 parent e36b9c6 commit 6ef1945
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions bigquery/storage/managedwriter/integration_test.go
Expand Up @@ -1498,6 +1498,7 @@ func TestIntegration_MultiplexWrites(t *testing.T) {
WithDestinationTable(TableParentFromParts(testTable.tbl.ProjectID, testTable.tbl.DatasetID, testTable.tbl.TableID)),
WithType(DefaultStream),
WithSchemaDescriptor(testTable.dp),
EnableWriteRetries(true),
)
if err != nil {
t.Fatalf("NewManagedStream %d: %v", k, err)
Expand Down

0 comments on commit 6ef1945

Please sign in to comment.