Skip to content

Commit

Permalink
test(storage): remove skip for objects.insert retry conformance test (#…
Browse files Browse the repository at this point in the history
…9637)

The implementation has been merged and released for bidi writes retries
  • Loading branch information
BrennaEpp committed Mar 27, 2024
1 parent d3fa28a commit fbeabdb
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions storage/retry_conformance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -523,9 +523,6 @@ func TestRetryConformance(t *testing.T) {
for _, transport := range transports {
testName := fmt.Sprintf("%v-%v-%v-%v-%v", transport, retryTest.Id, instructions.Instructions, methodName, i)
t.Run(testName, func(t *testing.T) {
if transport == "grpc" && method.Name == "storage.objects.insert" {
t.Skip("Implementation in testbench pending: https://github.com/googleapis/storage-testbench/issues/568")
}
// Create the retry subtest
subtest := &emulatorTest{T: t, name: testName, host: endpoint}
subtest.create(map[string][]string{
Expand Down

0 comments on commit fbeabdb

Please sign in to comment.