Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsublite): enforce minimum publisher and subscriber timeout of 2 minutes #7746

Merged
merged 6 commits into from Apr 21, 2023

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Apr 13, 2023

Low timeout values are harmful, as they cause the publisher or subscriber client to terminate if exceeded, which then causes confusion. If a value less than 2 minutes is set, it will be clamped to 2 minutes and a warning will be logged. In the future, a value less than 2 minutes will result in an error.

@tmdiep tmdiep requested review from a team and shollyman as code owners April 13, 2023 06:56
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsublite Issues related to the Pub/Sub Lite API. labels Apr 13, 2023
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@tmdiep tmdiep added the automerge Merge the pull request once unit tests and other checks pass. label Apr 21, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 89a9b0b into googleapis:main Apr 21, 2023
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 21, 2023
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants