Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update grpc to v1.55.0 #7885

Merged
merged 2 commits into from May 5, 2023
Merged

Conversation

noahdietz
Copy link
Contributor

Updates every module's dependency on google.golang.org/grpc to v1.55.0 in response to grpc/grpc-go#6252.

@noahdietz noahdietz requested review from a team, shollyman and bhshkh as code owners May 5, 2023 18:59
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 5, 2023
@noahdietz
Copy link
Contributor Author

cc: @BrennaEpp

Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Noah

@noahdietz noahdietz requested a review from quartzmo May 5, 2023 19:58
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should run go mod tidy for every go.mod with a command such as:

find . -name go.mod -execdir go mod tidy \;

When I do this, I see that the tidy operation removes the v1.54.0 entries from the go.sum files:

diff --git a/accessapproval/go.sum b/accessapproval/go.sum
index b8a5bf8bbd..30dede53fa 100644
--- a/accessapproval/go.sum
+++ b/accessapproval/go.sum
@@ -156,8 +156,6 @@ google.golang.org/grpc v1.33.1/go.mod h1:fr5YgcSWrqhRRxogOsw7RzIpsmvOZ6IcH4kBYTp
 google.golang.org/grpc v1.33.2/go.mod h1:JMHMWHQWaTccqQQlmk3MJZS+GWXOdAesneDmEnv2fbc=
 google.golang.org/grpc v1.36.0/go.mod h1:qjiiYl8FncCW8feJPdyg3v6XW24KsRHe+dy9BAGRRjU=
 google.golang.org/grpc v1.45.0/go.mod h1:lN7owxKUQEqMfSyQikvvk5tf/6zMPsrK+ONuO11+0rQ=
-google.golang.org/grpc v1.54.0 h1:EhTqbhiYeixwWQtAEZAxmV9MGqcjEU2mFx52xCzNyag=
-google.golang.org/grpc v1.54.0/go.mod h1:PUSEXI6iWghWaB6lXM4knEgpJNu2qUcKfDtNci3EC2g=
 google.golang.org/grpc v1.55.0 h1:3Oj82/tFSCeUrRTg/5E/7d/W5A1tj6Ky1ABAuZuv5ag=
 google.golang.org/grpc v1.55.0/go.mod h1:iYEXKGkEBhg1PjZQvoYEVPTDkHo1/bjTnfwTeGONTY8=
 google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd/go.mod h1:DFci5gLYBciE7Vtevhsrf46CRTquxDuWsQurQQe4oz8=

@noahdietz
Copy link
Contributor Author

I think you should run go mod tidy for every go.mod with a command such as:

Great call. Done!

@noahdietz noahdietz requested a review from quartzmo May 5, 2023 20:38
@noahdietz noahdietz merged commit 9fc48a9 into googleapis:main May 5, 2023
8 checks passed
@noahdietz noahdietz deleted the grpc-update branch May 5, 2023 21:32
gcf-merge-on-green bot pushed a commit that referenced this pull request May 18, 2023
Adds an `updateall` command that effectively implements a tool for what was done in #7885. 

This also refactors the logging helpers from `changefinder` into a shared package as `cloud.google.com/go/internal/actions/logg` so both action commands can use it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants