feat(bigquery/storage/managedwriter): refine connection metrics #8324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes metrics instrumentation in two ways: The AppendClientOpenView is now tagged with an error dimension, so that failures to open a connection are clearer. We use rpc status for the value, with the expectation that non-rpc errors are tagged as Unknown. A new metric (and view), AppendRequestReconnectsView provides additional visibility into when errors during Send trigger reconnection of the underlying connection. We attempt to also attribute this to the origin writer, so it may be tagged by error and source stream. Towards: googleapis#8311
product-auto-label
bot
added
size: s
|
👍 LGTM, thanks! |
alvarowolfx
approved these changes
Jul 25, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
🤖 I have created a release *beep* *boop* --- ## [1.54.0](https://togithub.com/googleapis/google-cloud-go/compare/bigquery/v1.53.0...bigquery/v1.54.0) (2023-08-17) ### Features * **bigquery/biglake:** Start generating apiv1 and apiv1alpha1 ([#8433](https://togithub.com/googleapis/google-cloud-go/issues/8433)) ([916f779](https://togithub.com/googleapis/google-cloud-go/commit/916f779a3513b2532d2e0fbd15bfd381ae3efeb5)) * **bigquery/datatransfer:** Add EncryptionConfiguration to TransferConfig ([e3f8c89](https://togithub.com/googleapis/google-cloud-go/commit/e3f8c89429a207c05fee36d5d93efe76f9e29efe)) * **bigquery/storage/managedwriter:** Refine connection metrics ([#8324](https://togithub.com/googleapis/google-cloud-go/issues/8324)) ([54fcf36](https://togithub.com/googleapis/google-cloud-go/commit/54fcf36fe7e26d6e3d11deec19f56e92ceb87d34)) * **bigquery/storage:** Add beta2 deprecation message ([b3dbdde](https://togithub.com/googleapis/google-cloud-go/commit/b3dbdde48ddfa215c3c3bb110e0051fd8158f451)) * **bigquery/storage:** Add default_missing_value_interpretation field; indicate KMS_SERVICE_ERROR is retryable ([b3dbdde](https://togithub.com/googleapis/google-cloud-go/commit/b3dbdde48ddfa215c3c3bb110e0051fd8158f451)) * **bigquery:** Add ProjectID to JobIDConfig ([#8405](https://togithub.com/googleapis/google-cloud-go/issues/8405)) ([7fafd80](https://togithub.com/googleapis/google-cloud-go/commit/7fafd805327a0734e1602a597c2ded09a860f405)) ### Bug Fixes * **bigquery/datapolicies:** Sync the new PredefinedEpxression types to the client library ([fcb41cc](https://togithub.com/googleapis/google-cloud-go/commit/fcb41cc1d2435452ee78314c1b0362e3f21ae637)) * **bigquery:** Use JobFromProject for storage iterator ([#8372](https://togithub.com/googleapis/google-cloud-go/issues/8372)) ([bfbf18c](https://togithub.com/googleapis/google-cloud-go/commit/bfbf18cb373cd6a88a22eec8db7033f6678df755)) ### Documentation * **bigquery/storage/managedwriter:** Augment context usage in package docs ([#8334](https://togithub.com/googleapis/google-cloud-go/issues/8334)) ([b30a7f4](https://togithub.com/googleapis/google-cloud-go/commit/b30a7f4a520c358eb71e1378b98e7413c2ea7f81)) * **bigquery:** Improve RowIterator docs and out of process pagination with Storage API ([#8419](https://togithub.com/googleapis/google-cloud-go/issues/8419)) ([40f8f80](https://togithub.com/googleapis/google-cloud-go/commit/40f8f809d9ad1e6d2d0f6207cdf38428c306cb66)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This was referenced Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes metrics instrumentation in two ways:
The AppendClientOpenView is now tagged with an error dimension, so that failures to open a connection are clearer. We use grpc status code for the tagging, with the expectation that non-rpc errors are tagged as Unknown.
A new metric (and view), AppendRequestReconnectsView provides additional visibility into when errors during Send trigger reconnection of the underlying connection. We attempt to also attribute this to the origin writer, so it may be tagged by error (grpc status code again) and source stream.
Additional thanks to @tanner-bruce for additional suggestions here
Towards: #8311