Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vertexai): add UsageMetadata #9155

Merged
merged 1 commit into from Dec 13, 2023
Merged

Conversation

jba
Copy link
Contributor

@jba jba commented Dec 13, 2023

  • Add the UsageMetadata type, and the field of GenerateContentResponse that holds it.

  • Use protoveneer for GenerateContentResponse instead of writing it by hand.

  • Enable protoveneer to completely replace a doc comment.

  • Improve protoveneer doc comment handling.

- Add the UsageMetadata type, and the field of GenerateContentResponse
  that holds it.

- Use protoveneer for GenerateContentResponse instead of writing it by
  hand.

- Enable protoveneer to completely replace a doc comment.

- Improve protoveneer doc comment handling.
@jba jba added the automerge Merge the pull request once unit tests and other checks pass. label Dec 13, 2023
@jba jba requested a review from eliben December 13, 2023 17:03
@jba jba requested review from a team as code owners December 13, 2023 17:03
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 13, 2023
Copy link
Contributor

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have it generate more of the wrappers!

@gcf-merge-on-green gcf-merge-on-green bot merged commit 27498e0 into main Dec 13, 2023
13 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the jba-vertexai-usagemeta branch December 13, 2023 17:10
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants