Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery): move MaxStaleness field to table level #10066

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix(bigquery): move MaxStaleness field to table level #10066

wants to merge 3 commits into from

Conversation

alvarowolfx
Copy link
Contributor

@alvarowolfx alvarowolfx commented Apr 30, 2024 •
edited

Sounds like updating MaxStaleness is not working, so an internal ticket was opened to check that part.

Fixes #10026

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Apr 30, 2024
shollyman
shollyman reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general looks reasonable, but I'd like more details on what the table level field may actually control.

bigquery/table.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigquery: max staleness cannot be retreived/updated
2 participants
@alvarowolfx @shollyman