Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner): Add ARRAY keywords to keywords #10079

Merged

Conversation

kai5263499
Copy link
Contributor

Fixes #10078

@kai5263499 kai5263499 requested review from a team as code owners May 1, 2024 18:02
@kai5263499 kai5263499 force-pushed the add_array_functions_to_keywords branch from b472898 to b547418 Compare May 1, 2024 18:04
@kai5263499 kai5263499 changed the title Add ARRAY keywords to keywords fix(spanner): Add ARRAY keywords to keywords May 1, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@kai5263499 kai5263499 force-pushed the add_array_functions_to_keywords branch from b547418 to 436fd77 Compare May 1, 2024 18:06
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label May 2, 2024
@kai5263499 kai5263499 force-pushed the add_array_functions_to_keywords branch from 436fd77 to 7814237 Compare May 2, 2024 12:54
@harshachinta
Copy link
Contributor

GoogleSQL supported Array functions - https://cloud.google.com/spanner/docs/reference/standard-sql/array_functions

@kai5263499
Copy link
Contributor Author

GoogleSQL supported Array functions - https://cloud.google.com/spanner/docs/reference/standard-sql/array_functions

This list appears to match what I've added in my PR. Is there something else I should add here?

@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@harshachinta
Copy link
Contributor

@kai5263499 Please add tests in parse_test.go similar to #9557?

@kai5263499
Copy link
Contributor Author

@kai5263499 Please add tests in parse_test.go similar to #9557?

I added tests. That led me to remove ARRAY_FILTER because it expects a lambda expression and that would need to be a brand new type for the parser to support. I'll create a separate issue to track the work that needs to be done to support it.

@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@harshachinta harshachinta merged commit 8e675cd into googleapis:main May 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner: ARRAY functions missing from keyword list
3 participants