chore: remove todo storage client grpc flag

[bgdnvk]

You already pushed this into main so this TODO shouldn't be here.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[tritone]

Thanks!

[bgdnvk]

From the logs:

    --- FAIL: TestRetryConformance/http-2-[return-reset-connection_return-reset-connection]-storage.objects.insert-1 (0.01s)
    --- PASS: TestRetryConformance/grpc-2-[return-reset-connection_return-reset-connection]-storage.objects.insert-1 (0.57s)

looks like an http insert has failed

[tritone]

From the logs:

    --- FAIL: TestRetryConformance/http-2-[return-reset-connection_return-reset-connection]-storage.objects.insert-1 (0.01s)
    --- PASS: TestRetryConformance/grpc-2-[return-reset-connection_return-reset-connection]-storage.objects.insert-1 (0.57s)

looks like an http insert has failed

This is most likely a test flake; I'll rerun.

[bgdnvk]

Failed again, might be an edge case since all others pass

--- FAIL: TestRetryConformance/http-2-[return-reset-connection_return-reset-connection]-storage.objects.insert-1 (0.03s)
from what i understand it's just an http connection and the client options haven't changed, the flag wasn't used there - perhaps in another test somehow? can dig more into it but im unfamiliar with the codebase

[bgdnvk]

The one failing is from the "earliest version"

[15:09:59 PDT] Child job: cloud-devrel/client-libraries/go/google-cloud-go/presubmit/latest-version finished with status: SUCCEEDED Url: https://source.cloud.google.com/results/invocations/e91b0f84-8d26-4ccd-a4c9-977173d74780
[15:10:34 PDT] Child job: cloud-devrel/client-libraries/go/google-cloud-go/presubmit/earliest-version finished with status: FAILED Url: https://source.cloud.google.com/results/invocations/9b23c3c7-4126-432c-8aab-6d45e97fbc5c

however from the successful run we have

=== RUN   TestRetryConformance/http-2-[return-reset-connection_return-reset-connection]-storage.objects.insert-1
    retry_conformance_test.go:634: want success, got Writer.Close: Post "http://localhost:9000/upload/storage/v1/b/bucket-20240517-79706071112773-0116/o?alt=json&ifGenerationMatch=0&name=new-object.txt&prettyPrint=false&projection=full&uploadType=multipart": write tcp 127.0.0.1:58030->127.0.0.1:9000: write: broken pipe