fix(auth): handle non-Transport DefaultTransport #10162
Merged
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
approved these changes
May 14, 2024
noahdietz
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 17, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.2](https://togithub.com/googleapis/google-cloud-go/compare/auth/v0.4.1...auth/v0.4.2) (2024-05-16) ### Bug Fixes * **auth:** Enable client certificates by default only for GDU ([#10151](https://togithub.com/googleapis/google-cloud-go/issues/10151)) ([7c52978](https://togithub.com/googleapis/google-cloud-go/commit/7c529786275a39b7e00525f7d5e7be0d963e9e15)) * **auth:** Handle non-Transport DefaultTransport ([#10162](https://togithub.com/googleapis/google-cloud-go/issues/10162)) ([fa3bfdb](https://togithub.com/googleapis/google-cloud-go/commit/fa3bfdb23aaa45b34394a8b61e753b3587506782)), refs [#10159](https://togithub.com/googleapis/google-cloud-go/issues/10159) * **auth:** Have refresh time match docs ([#10147](https://togithub.com/googleapis/google-cloud-go/issues/10147)) ([bcb5568](https://togithub.com/googleapis/google-cloud-go/commit/bcb5568c07a54dd3d2e869d15f502b0741a609e8)) * **auth:** Update compute token fetching error with named prefix ([#10180](https://togithub.com/googleapis/google-cloud-go/issues/10180)) ([4573504](https://togithub.com/googleapis/google-cloud-go/commit/4573504828d2928bebedc875d87650ba227829ea)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
http.DefaultTransportis aRoundTripperinterface and mutable global variable, it is not safe to assume it is always going to concretely be*http.Transport. If it is not, I suppose we should just use the value directly instead of making aClone. Thehttp.DefaultTransportbeing overridden is pretty intentional by application authors, so it is best if we respect that and just reuse it direct.Fixes #10159