chore(bigquery/storage/managedwriter): internal refactor (flow controller, ids) #7104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a new internal mechanism to simplify duplicating flow controllers, and does some preliminary work to wire in a UUID-based ID for managed stream instances. Neither is used elsewhere. Towards: googleapis#7103
product-auto-label
bot
added
size: m
shollyman
requested review from
alvarowolfx
and removed request for
mhaligowski
alvarowolfx
reviewed
Nov 30, 2022
| @@ -50,6 +50,17 @@ func newFlowController(maxInserts, maxInsertBytes int) *flowController { | |||
| return fc | |||
| } | |||
|
|
|||
| // copyFlowController is for creating a new flow controller based on | |||
| // settings from another. It does not copy flow state. | |||
| func copyFlowController(in *flowController) *flowController { | |||
There was a problem hiding this comment.
should this function go to the test file as is only being used there or there are plans to use it later ?
There was a problem hiding this comment.
This is in prep of future refactors, it will be used for replicating the flow controller as we spin up new connections.
alvarowolfx
approved these changes
Nov 30, 2022
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new internal mechanism to simplify duplicating flow controllers, and does some preliminary work to wire in a UUID-based ID for managed stream instances. Neither is used elsewhere at this time, but lay the foundation for further refactoring.
Towards: #7103