fix(bigquery): empty slice instead of nil slice for primitive repeated fields #7315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarowolfx
changed the title
product-auto-label
bot
added
size: m
product-auto-label
bot
added
the
stale: old
product-auto-label
bot
added
stale: extraold
|
@alvarowolfx do you have any progress? |
alvarowolfx
changed the title
alvarowolfx
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
shollyman
approved these changes
May 15, 2024
There was a problem hiding this comment.
The change itself is straightforward. We provide the most substantive guidance about value handling https://pkg.go.dev/cloud.google.com/go/bigquery#RowIterator.Next, is there anything you think we should include there to clarify this behavior?
I added more information on that section about empty vs null arrays, do you think looks good ? |
shollyman
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigQuery translates a NULL array into an empty array in the query result, although inside the query, NULL and empty arrays are two distinct values. This change brings the translation on the Go side more similar to the BQ backend. More on: https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#array_nulls
Resolves #4950 #9383