refactor: migrate settings and options #7374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does more settings consolidation, and updates/adds new WriterOption options to propagate settings. In particular, this PR: * moves the AppendRows call options into streamSettings * adds a multiplex flag and option to streamSettings * adds a call function option into streamSettings This PR also updates managed stream to use the new option(s) as appropriate, but most of this is unused here and is in preparation for a larger cutover of functionality related to the new connection abstractions. Towards: googleapis#7103
shollyman
added
the
do not merge
shollyman
removed
the
do not merge
alvarowolfx
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does more settings consolidation, and updates/adds new WriterOption options to propagate settings.
In particular, this PR:
This PR also updates managed stream to use the new option(s) as appropriate, but most of this is unused here and is in preparation for a larger cutover of functionality related to the new connection abstractions.
Towards: #7103