refactor: augment poolRouter interface (and simpleRouter) #7508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR extends the poolRouter interface to allow writers to be registered and removed, and augments the existing simpleRouter to support the contract. PR adds a basic test of the router. A future refactor (when we wire up the new abstractions) will hook up the functionality properly. Towards: googleapis#7103
alvarowolfx
approved these changes
Mar 2, 2023
| if pool.router != nil { | ||
| return pool.router.writerAttach(writer) | ||
| } | ||
| return nil |
There was a problem hiding this comment.
when there is no router available, shouldn't this return an error ?
There was a problem hiding this comment.
good point, updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the poolRouter interface to include more lifecycle signalling:
The core problem this addresses is proper shutdown between the components. We need to propagate this information to shutdown cleanly so that connections can go away in response to their writers.
This PR also augments our existing simpleRouter to adhere to the enlarged interface contract. The pool attach/detach events are left unimplemented as we need to plumb this in when we wire up the abstractions end to end, which will happen when we rewire the internals to use the new abstractions.
A test has been added to assert simpleRouter state when writers are attached and removed.
Towards: #7103