refactor(bigquery/storage/managedwriter): flowcontroller byte reporting #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows the flowcontroller to report bytes in flight for flow controllers with a bounded byte definition. The primary connection load signals for a connection are the inserts/bytes in flight as reported by the flow controller, and this makes the bytes in flight a signal we can use. Important note: an unbounded flow controller will not report any bytes in flight. This avoids introducing odd situations due to size normalization where bytes tracked and the actual capacity of the semaphore could get out of sync. Towards: googleapis#7103
product-auto-label
bot
added
size: s
alvarowolfx
approved these changes
Mar 17, 2023
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the flowcontroller to report bytes in flight for flow controllers with a bounded byte definition. The primary connection load signals for a connection are the inserts/bytes in flight as reported by the flow controller, and this makes the bytes in flight a signal we can use.
Important note: an unbounded flow controller will not report any bytes in flight. This avoids introducing odd situations due to size normalization where bytes tracked and the actual capacity of the semaphore could get out of sync.
Towards: #7103