fix(vertexai): use opts in NewClient #9165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliben
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
|
Closing in favor of #9163 that was earlier |
|
Thanks for doing this, sorry I missed it. You can test by passing in your own endpoint option that's wrong, and looking for an error. |
jba
reviewed
Dec 13, 2023
| @@ -47,7 +47,8 @@ type Client struct { | |||
| // package. | |||
| func NewClient(ctx context.Context, projectID, location string, opts ...option.ClientOption) (*Client, error) { | |||
| apiEndpoint := fmt.Sprintf("%s-aiplatform.googleapis.com:443", location) | |||
| c, err := aiplatform.NewPredictionClient(ctx, option.WithEndpoint(apiEndpoint)) | |||
| opts = append(opts, option.WithEndpoint(apiEndpoint)) | |||
There was a problem hiding this comment.
Appending to opts could affect the caller.
Also we want the user opts to override whatever we do.
Follow this pattern: https://github.com/googleapis/google-cloud-go/blob/main/bigquery/storage_client.go#L59.
There was a problem hiding this comment.
Thanks! can you add these comments on #9163 ?
There was a problem hiding this comment.
Not necessary, #9163 is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9160