-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsub): add otel tracing support with links #9594
base: pubsub-otel-trace
Are you sure you want to change the base?
feat(pubsub): add otel tracing support with links #9594
Conversation
…sub-otel-trace-receive-clean
…/google-cloud-go into pubsub-otel-trace-receive-clean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of initial comments. I haven't gone too deep as I'm not super familiar here.
7341897
to
763a44e
Compare
…sub-otel-trace-links
…d-go into pubsub-otel-trace-links
if len(toRetry) > 0 { | ||
// Retry modacks/nacks in a separate goroutine. | ||
go func() { | ||
it.retryModAcks(toRetry, deadlineSec, logOnInvalid) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retryModAcks aren't traced, should they be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opting to not trace them currently. These retries are specific to exactly once delivery cases, and can be visualized by the multiple ModifyAckDeadline RPCs generated by the underlying library. If there's sufficient demand for this though, we'll consider adding later in a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense!
The recent changes from fixing the memory leaks now can result in the application crashing because of a |
@hongalex , thanks a lot for adding trace support for pubsub. I tried trace=6835bec8eafcfa19e76a02286d4b1f90 my manually created span with
I would expect to see |
@VladimirYushkevich Yeah so that is intentional. The reason is because the |
This replace #8592 and adds the missing subscribe side spans + updates the publish side spans to match our most recent design
Note: this PR uses an experimental golang.org/x/exp/slices package, which was added in go 1.21. This is only used for testing.