Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use docker-aligned filenames for kokoro configs #10829

Merged
merged 3 commits into from
May 15, 2024

Conversation

burkedavison
Copy link
Contributor

@burkedavison burkedavison commented May 10, 2024

This update should only be merged in sync with cl/632577295

Note the failure in the GraalVM presubmit checks are due to the filename change in the Kokoro configs:

[ERROR] Failed to get build config
com.google.devtools.kokoro.config.ConfigException: Couldn't find build configuration file graalvm-native-presubmit.

and

[ERROR] Failed to get build config
com.google.devtools.kokoro.config.ConfigException: Couldn't find build configuration file graalvm-native-17-presubmit.

@burkedavison burkedavison requested a review from a team as a code owner May 10, 2024 19:47
Copy link
Contributor

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@burkedavison
Copy link
Contributor Author

I've decided to take a phased approach to this change to ensure checks continue working rather than needing to sync internal+external changes with the chance of errors:

Phase 1: Add new configurations while leaving the existing configurations.
Phase 2: Update internal Kokoro configurations to point to new external configurations.
Phase 3: Remove configurations that are no longer being used.

@burkedavison burkedavison merged commit e46bc03 into main May 15, 2024
32 checks passed
@burkedavison burkedavison deleted the docker-aligned-filenames branch May 15, 2024 15:04
burkedavison added a commit that referenced this pull request May 22, 2024
* ci: use docker-aligned filenames for kokoro configs

* ci: re-add original configurations for phased rollout

* ci: revert required checks until after transition to new configs

(cherry picked from commit e46bc03)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants