Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per /grpc/grpc-java/issues/1772#issuecomment-364218818 #3826

Closed
wants to merge 1 commit into from

Conversation

kenfesta
Copy link

Per user feedback:

Description:
The Java docs for creating the channel are outdated. ManagedChannel channel = ManagedChannelBuilder.forTarget(hostport).usePlaintext(true).build(); should be ManagedChannel channel = ManagedChannelBuilder.forTarget(hostport).usePlaintext().build(); as the former version has been deprecated:

grpc/grpc-java#1772 (comment)

@kenfesta kenfesta requested a review from a team as a code owner October 16, 2018 17:17
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 16, 2018
@chingor13
Copy link
Contributor

Please fix the commit email address to be the one submitting the PR or sign the CLA with that email address.

@chingor13
Copy link
Contributor

Feel free to reopen once the CLA is fixed.

@chingor13 chingor13 closed this Nov 12, 2018
@kenfesta kenfesta deleted the remove-plaintext-true branch December 26, 2018 17:57
@kenfesta kenfesta restored the remove-plaintext-true branch December 26, 2018 18:05
@kenfesta kenfesta deleted the remove-plaintext-true branch December 26, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants