Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [clouddeploy] Add deploy parameters for cloud deploy #9570

Merged
merged 2 commits into from
Jun 22, 2023
Merged

feat: [clouddeploy] Add deploy parameters for cloud deploy #9570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
123ebd1
feat: Add deploy parameters for cloud deploy
gcf-owl-bot[bot] Jun 21, 2023
48d9481
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion java-deploy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>26.16.0</version>
<version>26.17.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
11 changes: 11 additions & 0 deletions ...-cloud-deploy/src/test/java/com/google/cloud/deploy/v1/CloudDeployClientHttpJsonTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,6 +745,7 @@ public void getTargetTest() throws Exception {
.setUpdateTime(Timestamp.newBuilder().build())
.setEtag("etag3123477")
.addAllExecutionConfigs(new ArrayList<ExecutionConfig>())
.putAllDeployParameters(new HashMap<String, String>())
.build();
mockService.addResponse(expectedResponse);

Expand Down Expand Up @@ -799,6 +800,7 @@ public void getTargetTest2() throws Exception {
.setUpdateTime(Timestamp.newBuilder().build())
.setEtag("etag3123477")
.addAllExecutionConfigs(new ArrayList<ExecutionConfig>())
.putAllDeployParameters(new HashMap<String, String>())
.build();
mockService.addResponse(expectedResponse);

Expand Down Expand Up @@ -853,6 +855,7 @@ public void createTargetTest() throws Exception {
.setUpdateTime(Timestamp.newBuilder().build())
.setEtag("etag3123477")
.addAllExecutionConfigs(new ArrayList<ExecutionConfig>())
.putAllDeployParameters(new HashMap<String, String>())
.build();
Operation resultOperation =
Operation.newBuilder()
Expand Down Expand Up @@ -916,6 +919,7 @@ public void createTargetTest2() throws Exception {
.setUpdateTime(Timestamp.newBuilder().build())
.setEtag("etag3123477")
.addAllExecutionConfigs(new ArrayList<ExecutionConfig>())
.putAllDeployParameters(new HashMap<String, String>())
.build();
Operation resultOperation =
Operation.newBuilder()
Expand Down Expand Up @@ -979,6 +983,7 @@ public void updateTargetTest() throws Exception {
.setUpdateTime(Timestamp.newBuilder().build())
.setEtag("etag3123477")
.addAllExecutionConfigs(new ArrayList<ExecutionConfig>())
.putAllDeployParameters(new HashMap<String, String>())
.build();
Operation resultOperation =
Operation.newBuilder()
Expand All @@ -1001,6 +1006,7 @@ public void updateTargetTest() throws Exception {
.setUpdateTime(Timestamp.newBuilder().build())
.setEtag("etag3123477")
.addAllExecutionConfigs(new ArrayList<ExecutionConfig>())
.putAllDeployParameters(new HashMap<String, String>())
.build();
FieldMask updateMask = FieldMask.newBuilder().build();

Expand Down Expand Up @@ -1043,6 +1049,7 @@ public void updateTargetExceptionTest() throws Exception {
.setUpdateTime(Timestamp.newBuilder().build())
.setEtag("etag3123477")
.addAllExecutionConfigs(new ArrayList<ExecutionConfig>())
.putAllDeployParameters(new HashMap<String, String>())
.build();
FieldMask updateMask = FieldMask.newBuilder().build();
client.updateTargetAsync(target, updateMask).get();
Expand Down Expand Up @@ -1270,6 +1277,7 @@ public void getReleaseTest() throws Exception {
.putAllTargetArtifacts(new HashMap<String, TargetArtifact>())
.putAllTargetRenders(new HashMap<String, Release.TargetRender>())
.setCondition(Release.ReleaseCondition.newBuilder().build())
.putAllDeployParameters(new HashMap<String, String>())
.build();
mockService.addResponse(expectedResponse);

Expand Down Expand Up @@ -1336,6 +1344,7 @@ public void getReleaseTest2() throws Exception {
.putAllTargetArtifacts(new HashMap<String, TargetArtifact>())
.putAllTargetRenders(new HashMap<String, Release.TargetRender>())
.setCondition(Release.ReleaseCondition.newBuilder().build())
.putAllDeployParameters(new HashMap<String, String>())
.build();
mockService.addResponse(expectedResponse);

Expand Down Expand Up @@ -1402,6 +1411,7 @@ public void createReleaseTest() throws Exception {
.putAllTargetArtifacts(new HashMap<String, TargetArtifact>())
.putAllTargetRenders(new HashMap<String, Release.TargetRender>())
.setCondition(Release.ReleaseCondition.newBuilder().build())
.putAllDeployParameters(new HashMap<String, String>())
.build();
Operation resultOperation =
Operation.newBuilder()
Expand Down Expand Up @@ -1477,6 +1487,7 @@ public void createReleaseTest2() throws Exception {
.putAllTargetArtifacts(new HashMap<String, TargetArtifact>())
.putAllTargetRenders(new HashMap<String, Release.TargetRender>())
.setCondition(Release.ReleaseCondition.newBuilder().build())
.putAllDeployParameters(new HashMap<String, String>())
.build();
Operation resultOperation =
Operation.newBuilder()
Expand Down
9 changes: 9 additions & 0 deletions ...y/google-cloud-deploy/src/test/java/com/google/cloud/deploy/v1/CloudDeployClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,7 @@ public void getTargetTest() throws Exception {
.setUpdateTime(Timestamp.newBuilder().build())
.setEtag("etag3123477")
.addAllExecutionConfigs(new ArrayList<ExecutionConfig>())
.putAllDeployParameters(new HashMap<String, String>())
.build();
mockCloudDeploy.addResponse(expectedResponse);

Expand Down Expand Up @@ -731,6 +732,7 @@ public void getTargetTest2() throws Exception {
.setUpdateTime(Timestamp.newBuilder().build())
.setEtag("etag3123477")
.addAllExecutionConfigs(new ArrayList<ExecutionConfig>())
.putAllDeployParameters(new HashMap<String, String>())
.build();
mockCloudDeploy.addResponse(expectedResponse);

Expand Down Expand Up @@ -779,6 +781,7 @@ public void createTargetTest() throws Exception {
.setUpdateTime(Timestamp.newBuilder().build())
.setEtag("etag3123477")
.addAllExecutionConfigs(new ArrayList<ExecutionConfig>())
.putAllDeployParameters(new HashMap<String, String>())
.build();
Operation resultOperation =
Operation.newBuilder()
Expand Down Expand Up @@ -841,6 +844,7 @@ public void createTargetTest2() throws Exception {
.setUpdateTime(Timestamp.newBuilder().build())
.setEtag("etag3123477")
.addAllExecutionConfigs(new ArrayList<ExecutionConfig>())
.putAllDeployParameters(new HashMap<String, String>())
.build();
Operation resultOperation =
Operation.newBuilder()
Expand Down Expand Up @@ -903,6 +907,7 @@ public void updateTargetTest() throws Exception {
.setUpdateTime(Timestamp.newBuilder().build())
.setEtag("etag3123477")
.addAllExecutionConfigs(new ArrayList<ExecutionConfig>())
.putAllDeployParameters(new HashMap<String, String>())
.build();
Operation resultOperation =
Operation.newBuilder()
Expand Down Expand Up @@ -1146,6 +1151,7 @@ public void getReleaseTest() throws Exception {
.putAllTargetArtifacts(new HashMap<String, TargetArtifact>())
.putAllTargetRenders(new HashMap<String, Release.TargetRender>())
.setCondition(Release.ReleaseCondition.newBuilder().build())
.putAllDeployParameters(new HashMap<String, String>())
.build();
mockCloudDeploy.addResponse(expectedResponse);

Expand Down Expand Up @@ -1206,6 +1212,7 @@ public void getReleaseTest2() throws Exception {
.putAllTargetArtifacts(new HashMap<String, TargetArtifact>())
.putAllTargetRenders(new HashMap<String, Release.TargetRender>())
.setCondition(Release.ReleaseCondition.newBuilder().build())
.putAllDeployParameters(new HashMap<String, String>())
.build();
mockCloudDeploy.addResponse(expectedResponse);

Expand Down Expand Up @@ -1264,6 +1271,7 @@ public void createReleaseTest() throws Exception {
.putAllTargetArtifacts(new HashMap<String, TargetArtifact>())
.putAllTargetRenders(new HashMap<String, Release.TargetRender>())
.setCondition(Release.ReleaseCondition.newBuilder().build())
.putAllDeployParameters(new HashMap<String, String>())
.build();
Operation resultOperation =
Operation.newBuilder()
Expand Down Expand Up @@ -1338,6 +1346,7 @@ public void createReleaseTest2() throws Exception {
.putAllTargetArtifacts(new HashMap<String, TargetArtifact>())
.putAllTargetRenders(new HashMap<String, Release.TargetRender>())
.setCondition(Release.ReleaseCondition.newBuilder().build())
.putAllDeployParameters(new HashMap<String, String>())
.build();
Operation resultOperation =
Operation.newBuilder()
Expand Down