Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): add test scope for grpc-google-common-protos. #9578

Merged
merged 1 commit into from
Jun 23, 2023
Merged

chore(deps): add test scope for grpc-google-common-protos. #9578

merged 1 commit into from
Jun 23, 2023

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Jun 23, 2023 •
edited

Followup on #9533.
grpc-google-common-protos dependency only needed for com.google.cloud.location.LocationsGrpc classes in test. add test scope to reflect that.

@zhumin8 zhumin8 merged commit 594e965 into main Jun 23, 2023
28 checks passed
@zhumin8 zhumin8 deleted the gke-backup-dep-fix branch June 23, 2023 18:29
@zhumin8 zhumin8 added the release-please:force-run To run release-please label Jun 23, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Jun 23, 2023
@zhumin8 zhumin8 added the release-please:force-run To run release-please label Jun 23, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhumin8 @meltsufin